-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Enforces regex constraints in some fields #6021
Merged
pcrespov
merged 7 commits into
ITISFoundation:master
from
pcrespov:is5964/model-recursive-config
Jul 4, 2024
Merged
🐛 Enforces regex constraints in some fields #6021
pcrespov
merged 7 commits into
ITISFoundation:master
from
pcrespov:is5964/model-recursive-config
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6021 +/- ##
=========================================
- Coverage 84.5% 82.0% -2.6%
=========================================
Files 10 1166 +1156
Lines 214 50795 +50581
Branches 25 562 +537
=========================================
+ Hits 181 41664 +41483
- Misses 23 9012 +8989
- Partials 10 119 +109
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…re set but not enforced: regex.fixes mocks
…aints are set but not enforced: regex. For more details see https://pydantic-docs.helpmanual.io/usage/schema/#unenforced-field-constraints
pcrespov
force-pushed
the
is5964/model-recursive-config
branch
from
July 4, 2024 10:20
8a13621
to
1261349
Compare
pcrespov
changed the title
WIP: 🎨 Is5964/model recursive config
🐛 Enforces regex constraints in some fields
Jul 4, 2024
bisgaard-itis
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
sanderegg
approved these changes
Jul 4, 2024
This was referenced Jul 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Field(... re=...)
byConstraintedStr
to avoid this errorRelated issue/s
maintenance
How to test