-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ New fakes in dev/catalog/service #6012
♻️ New fakes in dev/catalog/service #6012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6012 +/- ##
=========================================
+ Coverage 84.5% 88.4% +3.8%
=========================================
Files 10 1161 +1151
Lines 214 50585 +50371
Branches 25 562 +537
=========================================
+ Hits 181 44732 +44551
- Misses 23 5727 +5704
- Partials 10 126 +116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
What do these changes do?
Following up with @odeimaiz the
/dev/catalog/services
fakes will refer to sleepersRelated issue/s
How to test
Dev-ops checklist