Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ New fakes in dev/catalog/service #6012

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 28, 2024

What do these changes do?

Following up with @odeimaiz the /dev/catalog/services fakes will refer to sleepers

Related issue/s

How to test

cd packages/models-library
make install-dev
pytest -vv tests/test__model_examples.py

Dev-ops checklist

@pcrespov pcrespov self-assigned this Jun 28, 2024
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jun 28, 2024
@pcrespov pcrespov marked this pull request as ready for review June 28, 2024 13:24
@pcrespov pcrespov added this to the South Island Iced Tea milestone Jun 28, 2024
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pcrespov pcrespov requested a review from bisgaard-itis June 28, 2024 13:31
@pcrespov pcrespov enabled auto-merge (squash) June 28, 2024 13:34
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.4%. Comparing base (cafbf96) to head (c9a291d).
Report is 306 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6012      +/-   ##
=========================================
+ Coverage    84.5%   88.4%    +3.8%     
=========================================
  Files          10    1161    +1151     
  Lines         214   50585   +50371     
  Branches       25     562     +537     
=========================================
+ Hits          181   44732   +44551     
- Misses         23    5727    +5704     
- Partials       10     126     +116     
Flag Coverage Δ
integrationtests 64.7% <0.0%> (?)
unittests 86.1% <100.0%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/models_library/api_schemas_catalog/services.py 100.0% <ø> (ø)
...rc/models_library/api_schemas_webserver/catalog.py 100.0% <100.0%> (ø)
...src/simcore_service_webserver/catalog/_handlers.py 76.0% <100.0%> (ø)

... and 1150 files with indirect coverage changes

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@pcrespov pcrespov merged commit 4c53a12 into ITISFoundation:master Jul 1, 2024
56 checks passed
@pcrespov pcrespov deleted the is5964/updates-fake-services-example branch July 1, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants