-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ dynamic-sidecar logs changes to input ports #5999
Merged
GitHK
merged 9 commits into
ITISFoundation:master
from
GitHK:GitHK-sidecars-prints-port-data-after-pulling
Jun 27, 2024
Merged
✨ dynamic-sidecar logs changes to input ports #5999
GitHK
merged 9 commits into
ITISFoundation:master
from
GitHK:GitHK-sidecars-prints-port-data-after-pulling
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt-data-after-pulling
…:GitHK/osparc-simcore-forked into GitHK-sidecars-prints-port-data-after-pulling
GitHK
changed the title
Git hk sidecars prints port data after pulling
sidecars prints port data after pulling
Jun 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5999 +/- ##
=========================================
+ Coverage 84.5% 87.4% +2.8%
=========================================
Files 10 1113 +1103
Lines 214 48572 +48358
Branches 25 744 +719
=========================================
+ Hits 181 42487 +42306
- Misses 23 5923 +5900
- Partials 10 162 +152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
changed the title
sidecars prints port data after pulling
✨ dynamic-sidecar logs changes to input ports
Jun 26, 2024
GitHK
requested review from
wvangeit,
sanderegg,
elisabettai,
Konohana0608 and
odeimaiz
June 26, 2024 12:42
odeimaiz
approved these changes
Jun 26, 2024
wvangeit
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @GitHK
pcrespov
approved these changes
Jun 26, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Enhances the logs of the sidecar and prints which files were modified when pulling the inputs. This will allow to better help users with debugging their studies.
Related issue/s
How to test
Dev-ops checklist