Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ dynamic-sidecar logs changes to input ports #5999

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jun 26, 2024

What do these changes do?

Enhances the logs of the sidecar and prints which files were modified when pulling the inputs. This will allow to better help users with debugging their studies.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK changed the title Git hk sidecars prints port data after pulling sidecars prints port data after pulling Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.4%. Comparing base (cafbf96) to head (b3c3194).
Report is 302 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5999      +/-   ##
=========================================
+ Coverage    84.5%   87.4%    +2.8%     
=========================================
  Files          10    1113    +1103     
  Lines         214   48572   +48358     
  Branches       25     744     +719     
=========================================
+ Hits          181   42487   +42306     
- Misses         23    5923    +5900     
- Partials       10     162     +152     
Flag Coverage Δ
integrationtests 63.6% <33.3%> (?)
unittests 85.2% <100.0%> (+0.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...kages/service-library/src/servicelib/file_utils.py 87.5% <100.0%> (ø)
...vice_dynamic_sidecar/modules/long_running_tasks.py 95.2% <100.0%> (ø)

... and 1121 files with indirect coverage changes

@GitHK GitHK self-assigned this Jun 26, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Jun 26, 2024
@GitHK GitHK changed the title sidecars prints port data after pulling ✨ dynamic-sidecar logs changes to input ports Jun 26, 2024
@GitHK GitHK marked this pull request as ready for review June 26, 2024 12:42
@GitHK GitHK requested a review from pcrespov as a code owner June 26, 2024 12:42
@GitHK GitHK added this to the South Island Iced Tea milestone Jun 26, 2024
Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @GitHK

@GitHK GitHK enabled auto-merge (squash) June 27, 2024 05:28
@GitHK GitHK merged commit 87d3354 into ITISFoundation:master Jun 27, 2024
56 checks passed
@GitHK GitHK deleted the GitHK-sidecars-prints-port-data-after-pulling branch June 27, 2024 05:54
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants