Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Fixes Deprecation Warning on redis and aiohttp #5996

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 25, 2024

What do these changes do?

Fixes deprecation warning in redis library, provided that redis==5.0.4 already repo-wide

DeprecationWarning: Call to deprecated close. (Use aclose() instead) -- Deprecated since version 5.0.1.
    await client.close(close_connection_pool=True)
 ... /aiohttp/web_protocol.py:451: DeprecationWarning: returning HTTPException object is deprecated (#2415) and will be removed, please raise the exception instead

@pcrespov pcrespov added this to the South Island Iced Tea milestone Jun 25, 2024
@pcrespov pcrespov self-assigned this Jun 25, 2024
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jun 25, 2024
@pcrespov pcrespov enabled auto-merge (squash) June 25, 2024 16:50
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.4%. Comparing base (cafbf96) to head (6f2b552).
Report is 301 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5996      +/-   ##
=========================================
+ Coverage    84.5%   88.4%    +3.9%     
=========================================
  Files          10    1295    +1285     
  Lines         214   53713   +53499     
  Branches       25     820     +795     
=========================================
+ Hits          181   47534   +47353     
- Misses         23    6004    +5981     
- Partials       10     175     +165     
Flag Coverage Δ
integrationtests 64.7% <28.5%> (?)
unittests 86.3% <14.2%> (+1.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...simcore_service_webserver/director_v2/_handlers.py 92.5% <28.5%> (ø)

... and 1266 files with indirect coverage changes

@pcrespov pcrespov changed the title 🎨 Fixes DeprecationWarning on redis 🎨 Fixes Deprecation Warning on redis and aiohttp Jun 25, 2024
@pcrespov pcrespov merged commit b5d82e0 into ITISFoundation:master Jun 26, 2024
56 checks passed
@pcrespov pcrespov deleted the mai/fix-warnings branch June 26, 2024 12:25
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants