-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Fixes Deprecation Warning on redis and aiohttp #5996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
requested review from
sanderegg,
GitHK and
matusdrobuliak66
as code owners
June 25, 2024 16:49
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5996 +/- ##
=========================================
+ Coverage 84.5% 88.4% +3.9%
=========================================
Files 10 1295 +1285
Lines 214 53713 +53499
Branches 25 820 +795
=========================================
+ Hits 181 47534 +47353
- Misses 23 6004 +5981
- Partials 10 175 +165
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
changed the title
🎨 Fixes DeprecationWarning on redis
🎨 Fixes Deprecation Warning on redis and aiohttp
Jun 25, 2024
pcrespov
force-pushed
the
mai/fix-warnings
branch
from
June 25, 2024 17:00
8acc673
to
d38e966
Compare
sanderegg
approved these changes
Jun 25, 2024
GitHK
approved these changes
Jun 26, 2024
pcrespov
force-pushed
the
mai/fix-warnings
branch
from
June 26, 2024 09:45
4a00ba1
to
d554a52
Compare
…o deprecated close. (Use aclose() instead) -- Deprecated since version 5.0.1.fixes code in tests
…rams is forbiddene2e tests
pcrespov
force-pushed
the
mai/fix-warnings
branch
from
June 26, 2024 11:09
55c9c66
to
6f2b552
Compare
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes deprecation warning in
redis
library, provided thatredis==5.0.4
already repo-wideaiohttp
library (SEE Deprecate returning web.HTTPException from handlers and middlewares aio-libs/aiohttp#2415)