✨ Implementing new list_services_paginated entrypoint in web-api (part 1)

[pcrespov]

What do these changes do?

In PR #6003 we implemented a new rpc interface in the catalog and connected it with the rest api of the webserver service. This PR partially implements api.rpc._services.list_services_paginated.

Specifically:

• implements repository layer (i.e. db.repositories.services)
• implements services layer (i.e. services.catalog.list_services_paginated)
  • only the data from the database is included.
  • data from image labels is still not included
• connects controller layer (i.e. api.rpc._services) to service layer
• ♻️ Adapting ServiceGetV2 model in coordination with @odeimaiz

Following up PRs will cover:

• connection with registry/director
• compatibility rules

Related issue/s

• Follows up from ✨ webserver-catalog rpc connection #6003
• Part of Front-end uses new catalog/services/* web API entrypoint #5964

How to test

Driving tests

• services/catalog/tests/unit/with_dbs/test_db_repositories.py
• Manual exploratory test: use /dev/catalog/services-
  • set WEBSERVER_DEV_FEATURE_ENABLED=1 (i.e. configuration in master deploy)
  • start stack
  • open swagger at /dev/doc
  • execute GET /dev/catalog/services/-/latest. Expected fast and short response body
  • compare with GET /catalog/services/latest. Expected slow and long response body

Dev-ops checklist

None

[codecov]

Codecov Report

Attention: Patch coverage is 95.29412% with 8 lines in your changes missing coverage. Please review.

Project coverage is 87.7%. Comparing base (cafbf96) to head (1550b6c).
Report is 319 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5991      +/-   ##
=========================================
+ Coverage    84.5%   87.7%    +3.2%     
=========================================
  Files          10    1289    +1279     
  Lines         214   55418   +55204     
  Branches       25    1101    +1076     
=========================================
+ Hits          181   48648   +48467     
- Misses         23    6531    +6508     
- Partials       10     239     +229     

Flag	Coverage Δ
integrationtests	64.7% <ø> (?)
unittests	85.7% <95.2%> (+1.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...src/models_library/api_schemas_catalog/services.py	100.0% <100.0%> (ø)
...dels-library/src/models_library/services_access.py	100.0% <ø> (ø)
...s-library/src/models_library/services_authoring.py	100.0% <100.0%> (ø)
...els-library/src/models_library/services_history.py	100.0% <100.0%> (ø)
...icelib/rabbitmq/rpc_interfaces/catalog/services.py	0.0% <ø> (ø)
.../src/simcore_service_catalog/api/rest/_services.py	59.3% <100.0%> (ø)
...ervice_catalog/api/rest/_services_access_rights.py	100.0% <100.0%> (ø)
...g/src/simcore_service_catalog/api/rpc/_services.py	100.0% <100.0%> (ø)
...e_service_catalog/db/repositories/_services_sql.py	100.0% <100.0%> (ø)
.../simcore_service_catalog/db/repositories/groups.py	56.7% <100.0%> (ø)
... and 5 more

... and 1267 files with indirect coverage changes

[sanderegg]

thanks

[odeimaiz]

👍

[matusdrobuliak66]

Thanks