-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️🐛Storage: disable handling of dangling multipart uploads #5978
♻️🐛Storage: disable handling of dangling multipart uploads #5978
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5978 +/- ##
=========================================
- Coverage 84.5% 66.4% -18.2%
=========================================
Files 10 599 +589
Lines 214 30403 +30189
Branches 25 205 +180
=========================================
+ Hits 181 20205 +20024
- Misses 23 10147 +10124
- Partials 10 51 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
22f291d
to
edc9546
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we need ITISFoundation/osparc-ops-environments#702 to merge firsts, right?
@pcrespov not really, as how I understand it, the AWS rule will abort any multipart upload older than a few days (which time we can choose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool, but I am still not sure I fully understand the mechanism
What do these changes do?
Related issue/s
How to test
Dev-ops checklist