Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️🐛Storage: disable handling of dangling multipart uploads #5978

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 20, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Jun 20, 2024
@sanderegg sanderegg added this to the South Island Iced Tea milestone Jun 20, 2024
@sanderegg sanderegg self-assigned this Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.4%. Comparing base (cafbf96) to head (a03c4a8).
Report is 289 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5978      +/-   ##
=========================================
- Coverage    84.5%   66.4%   -18.2%     
=========================================
  Files          10     599     +589     
  Lines         214   30403   +30189     
  Branches       25     205     +180     
=========================================
+ Hits          181   20205   +20024     
- Misses         23   10147   +10124     
- Partials       10      51      +41     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 91.5% <100.0%> (+6.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rage/src/simcore_service_storage/simcore_s3_dsm.py 94.3% <100.0%> (ø)

... and 608 files with indirect coverage changes

@sanderegg sanderegg force-pushed the storage/expire-multipart-uploads branch from 22f291d to edc9546 Compare June 20, 2024 13:49
@sanderegg sanderegg marked this pull request as ready for review June 20, 2024 13:49
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks a lot

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need ITISFoundation/osparc-ops-environments#702 to merge firsts, right?

@sanderegg
Copy link
Member Author

So we need ITISFoundation/osparc-ops-environments#702 to merge firsts, right?

@pcrespov not really, as how I understand it, the AWS rule will abort any multipart upload older than a few days (which time we can choose)

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, but I am still not sure I fully understand the mechanism

@sanderegg sanderegg merged commit ad2d3e3 into ITISFoundation:master Jun 20, 2024
56 checks passed
@sanderegg sanderegg deleted the storage/expire-multipart-uploads branch June 20, 2024 15:38
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor storage to not take care of incomplete multipart uploads anymore
5 participants