-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Drafts new web-api for catalog services #5969
🎨 Drafts new web-api for catalog services #5969
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5969 +/- ##
=========================================
+ Coverage 84.5% 86.3% +1.7%
=========================================
Files 10 1161 +1151
Lines 214 50763 +50549
Branches 25 562 +537
=========================================
+ Hits 181 43843 +43662
- Misses 23 6794 +6771
- Partials 10 126 +116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e2b26d4
to
198bc11
Compare
198bc11
to
eecc67f
Compare
packages/models-library/src/models_library/api_schemas_webserver/catalog.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/catalog.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments, that we can discuss. thanks
packages/models-library/src/models_library/api_schemas_webserver/catalog.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool. I am not sure I actually understand the details of how it will work.
packages/models-library/src/models_library/api_schemas_webserver/catalog.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/catalog.py
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/info/ServiceLarge.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
What do these changes do?
This PR drafts new entrypoints for the web-api for
catalog/services
collection. SpecificallyThese entrypoints have been redesigned to:
NOTE: these entrypoints are only available with
WEBSERVER_DEV_FEATURES_ENABLED=1
, i.e. only available in master for testing.Hightlights
history
field with with all the releases of the service.history
also includes information on version compatibility that will now be resolved in the backend. Therefore, given a service,history[*].compatibility.can_update_to
history[0]
service_metadata_...
model variantsRelated issue/s
services/web/server/tests/unit/with_dbs/01/test_catalog_handlers__services.py
How to test
dev
entrypoints. They provide fake data but it is consistent with new modelsDev-ops checklist
None