Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Highlight elements in Guided Tour #5967

Merged
merged 3 commits into from
Jun 19, 2024
Merged

🎨 [Frontend] Highlight elements in Guided Tour #5967

merged 3 commits into from
Jun 19, 2024

Conversation

odeimaiz
Copy link
Member

What do these changes do?

As requested by some of you, the main elements in the Guided Tour are now highlighted:
Blankets

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jun 19, 2024
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners June 19, 2024 13:34
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 19, 2024
@odeimaiz odeimaiz added this to the South Island Iced Tea milestone Jun 19, 2024
ignapas
ignapas approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice blankets :D

@odeimaiz
Copy link
Member Author

nice blankets :D

Thank you for the nice approach!!

GitHK
GitHK approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy ✨

elisabettai
elisabettai approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot!

You can maybe make the contrast between the highlighted elements and rest even bigger.

pcrespov
pcrespov reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz
Copy link
Member Author

Nice, thanks a lot!

You can maybe make the contrast between the highlighted elements and rest even bigger.

0.4 is the opacity value used throughout the application for highlighting modal items. I would rather stick to the same value 👍

@odeimaiz odeimaiz enabled auto-merge (squash) June 19, 2024 14:02
@odeimaiz odeimaiz disabled auto-merge June 19, 2024 14:11
@odeimaiz odeimaiz merged commit 417e66f into ITISFoundation:master Jun 19, 2024
50 checks passed
@YuryHrytsuk YuryHrytsuk mentioned this pull request Jun 20, 2024
Closed
14 tasks
@GitHK GitHK mentioned this pull request Jun 27, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@sanderegg sanderegg Awaiting requested review from sanderegg

@Konohana0608 Konohana0608 Awaiting requested review from Konohana0608

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
South Island Iced Tea
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @ignapas @GitHK @elisabettai @pcrespov