🎨 [Frontend] Switch to iframe's content also after 302 response #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
ignapas
approved these changes
Jun 19, 2024
1 task
14 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Sometimes webkit based e2e tests still fail when switching from the loading page to the iframe's content.
The problem is that the frontend polls the state of the dynamic service and when this says
Ready(which is the containers status) the frontend still needs to make sure the url is reachable, because some traefik rules that need to be added might not be there yet. In this "ping" call from the frontend to the dynamic service's content, the backend might respond with a 302 Redirection Found, which is not ok, but it's still valid for a our purpose.Related issue/s
How to test
Dev-ops checklist