Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛? [Frontend bugfix?] Directly switch to service's iframe when its status is running #5948

Merged
merged 8 commits into from
Jun 17, 2024
Merged

🐛? [Frontend bugfix?] Directly switch to service's iframe when its status is running #5948

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e9c463e
directly switch services iframe
odeimaiz Jun 14, 2024
07ca705
comment
odeimaiz Jun 14, 2024
4500f33
comments
odeimaiz Jun 14, 2024
d06c80e
Merge branch 'master' into maybefix/swith-to-iframes-content
odeimaiz Jun 17, 2024
b475ab6
do waitForServiceReady (successful ping)
odeimaiz Jun 17, 2024
878b585
Merge branch 'maybefix/swith-to-iframes-content' of github.com:odeima…
odeimaiz Jun 17, 2024
3b7112b
comment
odeimaiz Jun 17, 2024
998d86e
remove comments
odeimaiz Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion services/static-webserver/client/source/class/osparc/data/model/Node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,7 +1245,13 @@ qx.Class.define("osparc.data.model.Node", {
} = osparc.utils.Utils.computeServiceUrl(data);
this.setDynamicV2(isDynamicV2);
if (srvUrl) {
this.__waitForServiceReady(srvUrl);
// this.__waitForServiceReady(srvUrl);
// instead of
// - waiting for the service to be ready (pings) and ...
// - request its frontend to make sure it is ready and ...
// - wait for the "load" event triggered by the content of the iframe
// we will skip those steps and directly switch its iframe
this.__serviceReadyIn(srvUrl);
}
break;
}
Expand Down
Loading