Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 disable health check for Redis client #5946

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jun 14, 2024

What do these changes do?

This is an attempt to fix the broken CI due to hanging tests.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jun 14, 2024
@GitHK GitHK added a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work labels Jun 14, 2024
@sanderegg sanderegg marked this pull request as ready for review June 14, 2024 10:37
@sanderegg sanderegg requested a review from pcrespov as a code owner June 14, 2024 10:37
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.5%. Comparing base (cafbf96) to head (f1f5992).
Report is 268 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5946      +/-   ##
=========================================
+ Coverage    84.5%   87.5%    +2.9%     
=========================================
  Files          10    1110    +1100     
  Lines         214   48341   +48127     
  Branches       25     725     +700     
=========================================
+ Hits          181   42320   +42139     
- Misses         23    5857    +5834     
- Partials       10     164     +154     
Flag Coverage Δ
integrationtests 64.6% <ø> (?)
unittests 85.2% <100.0%> (+0.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/service-library/src/servicelib/redis.py 93.3% <100.0%> (ø)

... and 1104 files with indirect coverage changes

@sanderegg sanderegg self-requested a review June 14, 2024 11:21
@sanderegg sanderegg merged commit 7b2d66a into ITISFoundation:master Jun 14, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-disable-health-redis branch June 14, 2024 11:46
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants