Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend bugfix] List everyone group and provide product-everyone group in potential collaborators #5945

Merged
merged 22 commits into from
Jun 17, 2024
Merged

🐛 [Frontend bugfix] List everyone group and provide product-everyone group in potential collaborators #5945

merged 22 commits into from
Jun 17, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 14, 2024 •
edited
Loading

What do these changes do?

Fixes:

  • List Everyone in current collaborators list
  • List Product Everyone in current collaborators list

Improvements:

  • Do NOT list Everyone in potential collaborators
  • Do NOT list Product Everyone in potential collaborators for Studies
  • DO list Product Everyone in potential collaborators Templates if user is at least Tester
  • DO list Product Everyone in potential collaborators for Services
  • Stop using hardcoded Everyone info, use the one provided by the backend
  • Do not list Everyone in the Publish as Template options

Studies:
Studies

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jun 14, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Jun 14, 2024
@odeimaiz odeimaiz added this to the South Island Iced Tea milestone Jun 14, 2024
@odeimaiz odeimaiz marked this pull request as ready for review June 14, 2024 12:49
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners June 14, 2024 12:49
GitHK
GitHK reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) June 14, 2024 13:05
elisabettai
elisabettai approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

My only concern is the "Product Everyone": regular users have no idea of what that is.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@odeimaiz
Copy link
Member Author

My only concern is the "Product Everyone": regular users have no idea of what that is.

The text show was "Public for Product users". I changed it to "Available to all users".

pcrespov
pcrespov reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz disabled auto-merge June 17, 2024 07:57
@odeimaiz odeimaiz enabled auto-merge (squash) June 17, 2024 08:00
@odeimaiz odeimaiz merged commit bfab27a into ITISFoundation:master Jun 17, 2024
51 checks passed
@YuryHrytsuk YuryHrytsuk mentioned this pull request Jun 20, 2024
Closed
14 tasks
@GitHK GitHK mentioned this pull request Jun 27, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
Closed
26 tasks
@odeimaiz odeimaiz deleted the fix/share-with-everyone branch August 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK left review comments

@sanderegg sanderegg sanderegg approved these changes

@elisabettai elisabettai elisabettai approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@mguidon mguidon Awaiting requested review from mguidon

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
South Island Iced Tea
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @ignapas @GitHK @elisabettai @pcrespov @sanderegg