-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 create efs guardian specific user ⚠️ DEVOPS #5936
🎨 create efs guardian specific user ⚠️ DEVOPS #5936
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5936 +/- ##
=========================================
+ Coverage 84.5% 87.7% +3.1%
=========================================
Files 10 1425 +1415
Lines 214 58465 +58251
Branches 25 1396 +1371
=========================================
+ Hits 181 51306 +51125
- Misses 23 6865 +6842
- Partials 10 294 +284
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…6/osparc-simcore into create-efs-guardian-user
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, regarding the handling of the ENVs
services/efs-guardian/src/simcore_service_efs_guardian/services/efs_manager.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. No comments to add from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider these suggestions.
thx
services/efs-guardian/src/simcore_service_efs_guardian/services/efs_manager.py
Outdated
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/efs_manager.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me know when this is done
What do these changes do?
Related issue/s
How to test
Dev-ops checklist
https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/667