Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 create efs guardian specific user ⚠️ DEVOPS #5936

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jun 12, 2024

What do these changes do?

  • The Guardian will run as user 8006.
  • When the Guardian creates a directory in the distributed file system, which is then mounted to the sidecar/user services, this directory will be created by the Guardian as EFS user 8006. However, the group will be efs-group, of which user 8004 is a member.
  • This will allow the Guardian to change the permissions for user 8004 (aka the sidecar/user service) if necessary.

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.7%. Comparing base (cafbf96) to head (f9db542).
Report is 316 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5936      +/-   ##
=========================================
+ Coverage    84.5%   87.7%    +3.1%     
=========================================
  Files          10    1425    +1415     
  Lines         214   58465   +58251     
  Branches       25    1396    +1371     
=========================================
+ Hits          181   51306   +51125     
- Misses         23    6865    +6842     
- Partials       10     294     +284     
Flag Coverage Δ
integrationtests 63.6% <ø> (?)
unittests 85.9% <100.0%> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/simcore_service_efs_guardian/core/settings.py 100.0% <100.0%> (ø)
...mcore_service_efs_guardian/services/efs_manager.py 100.0% <100.0%> (ø)

... and 1387 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 12, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 14, 2024 11:34
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, regarding the handling of the ENVs

services/efs-guardian/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. No comments to add from my side

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider these suggestions.
thx

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know when this is done

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) July 3, 2024 12:36
@matusdrobuliak66 matusdrobuliak66 merged commit ba9c6b3 into ITISFoundation:master Jul 3, 2024
56 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the create-efs-guardian-user branch July 3, 2024 17:04
@YuryHrytsuk YuryHrytsuk changed the title 🎨 create efs guardian specific user 🎨 create efs guardian specific user ⚠️ DEVOPS Jul 4, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants