Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Dashboard: Filter Services by Type #5930

Merged
merged 18 commits into from
Jun 12, 2024
Merged

🎨 [Frontend] Dashboard: Filter Services by Type #5930

merged 18 commits into from
Jun 12, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 10, 2024 •
edited
Loading

What do these changes do?

This PR adds the Service Type filter Services tab, both to the left side filter and to the menu of the search bar.

ServiceTypeFilter

Related issue/s

closes ITISFoundation/osparc-issues#1013

How to test

Dev-ops checklist

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 10, 2024
@odeimaiz odeimaiz added this to the South Island Iced Tea milestone Jun 10, 2024
@odeimaiz odeimaiz self-assigned this Jun 10, 2024
@odeimaiz odeimaiz changed the title createServiceTypeFilterLayout 🎨 [Frontend] Dashboard: Filter Services by Type Jun 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 10, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@odeimaiz odeimaiz marked this pull request as ready for review June 11, 2024 09:53
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners June 11, 2024 09:53
@odeimaiz odeimaiz enabled auto-merge (squash) June 11, 2024 09:54
elisabettai
elisabettai approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, and finally we have the filter for types there as well!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ignapas
ignapas approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@odeimaiz odeimaiz merged commit efe5bb1 into ITISFoundation:master Jun 12, 2024
51 checks passed
@YuryHrytsuk YuryHrytsuk mentioned this pull request Jun 20, 2024
Closed
14 tasks
@GitHK GitHK mentioned this pull request Jun 27, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
Closed
26 tasks
@odeimaiz odeimaiz deleted the enh/dashboard-service-filter branch August 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
South Island Iced Tea
Development

Successfully merging this pull request may close these issues.

Filter services by type in the Services tabs
5 participants
@odeimaiz @ignapas @GitHK @elisabettai @sanderegg