♻️ Major cleanup of catalog service #5904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
added
a:services-library
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5904 +/- ##
=========================================
+ Coverage 84.5% 88.6% +4.0%
=========================================
Files 10 937 +927
Lines 214 41367 +41153
Branches 25 932 +907
=========================================
+ Hits 181 36663 +36482
- Misses 23 4495 +4472
- Partials 10 209 +199
Flags with carried forward coverage won't be shown. Click here to find out more. |
pcrespov
force-pushed
the
is1404/mai-service-catalog
branch
2 times, most recently
from
0e90e21
to
8945bd7
Compare
pcrespov
changed the title
pcrespov
requested review from
sanderegg,
bisgaard-itis,
mrnicegyu11 and
YuryHrytsuk
as code owners
mrnicegyu11
reviewed
Jun 4, 2024
GitHK
approved these changes
Jun 4, 2024
services/catalog/src/simcore_service_catalog/db/repositories/services.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/exceptions/handlers/__init__.py
Outdated
Show resolved
Hide resolved
services/catalog/tests/unit/with_dbs/test_api_routes_services__list.py
Outdated
Show resolved
Hide resolved
mrnicegyu11
approved these changes
Jun 4, 2024
sanderegg
reviewed
Jun 4, 2024
services/catalog/src/simcore_service_catalog/api/routes/services.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/core/background_tasks.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/db/repositories/projects.py
Outdated
Show resolved
Hide resolved
YuryHrytsuk
approved these changes
Jun 5, 2024
|
bisgaard-itis
approved these changes
Jun 5, 2024
services/catalog/src/simcore_service_catalog/api/routes/services_resources.py
Show resolved
Hide resolved
|
Thanks 👍 |
This was referenced Jun 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a large cleanup refactoring of
catalogbefore modifying its functionality for the related issues mentioned below.Highlights
Annotationsecho-envfileenv-develandextra-docker-compose.yamlMakefileand service CLI withecho-envfilecommandREADMEservices/catalog/src/simcore_service_catalog/core/background_tasks.py- enhanced and reduced tests fixtures by using
pytest_simcoreassetsRelated issue/s
version_displayandrelease_datefields for service metadata #5902How to test
cd services/catalog make install-dev make test-dev-unitDev-ops checklist
CATALOG_BACKGROUND_TASK_REST_TIMEwas missing