-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add EFS mount option to sidecar #5873
✨ add EFS mount option to sidecar #5873
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5873 +/- ##
=========================================
- Coverage 84.5% 80.2% -4.4%
=========================================
Files 10 1404 +1394
Lines 214 57834 +57620
Branches 25 1330 +1305
=========================================
+ Hits 181 46422 +46241
- Misses 23 11136 +11113
- Partials 10 276 +266
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…atusdrobuliak66/osparc-simcore into efs/add-create-directory-functionality
…o mount-efs-to-sidecar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments
...r-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/sidecar.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/volumes.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to some feedback, I think you can maybe convince me with some words to accept as-is ;) Thanks!
services/director-v2/src/simcore_service_director_v2/core/dynamic_services_settings/sidecar.py
Show resolved
Hide resolved
...r-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/sidecar.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/volumes.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/volumes.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for considering my input!
Quality Gate passedIssues Measures |
What do these changes do?
Related issue/s
How to test
Dev-ops checklist
EFS_ENABLED_FOR_USERS
--> already added to aws master in config repo