Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add EFS mount option to sidecar #5873

Merged
merged 44 commits into from
Jun 10, 2024

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented May 27, 2024

What do these changes do?

  • ✨ add EFS mount option to sidecar (only if it is enabled for a specific user - this is temporary for testing purpose)

Related issue/s

How to test

Dev-ops checklist

  • New variable EFS_ENABLED_FOR_USERS --> already added to aws master in config repo
  • No ENV changes or I properly updated ENV (read the instruction)

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 27, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Leeroy Jenkins milestone May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 77.08333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.2%. Comparing base (cafbf96) to head (38f1428).
Report is 260 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5873      +/-   ##
=========================================
- Coverage    84.5%   80.2%    -4.4%     
=========================================
  Files          10    1404    +1394     
  Lines         214   57834   +57620     
  Branches       25    1330    +1305     
=========================================
+ Hits          181   46422   +46241     
- Misses         23   11136   +11113     
- Partials       10     276     +266     
Flag Coverage Δ
integrationtests 41.5% <ø> (?)
unittests 79.9% <77.0%> (-4.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...abbitmq/rpc_interfaces/efs_guardian/efs_manager.py 0.0% <ø> (ø)
...kages/settings-library/src/settings_library/efs.py 100.0% <100.0%> (ø)
...ector_v2/core/dynamic_services_settings/sidecar.py 96.1% <100.0%> (ø)
...core_service_efs_guardian/api/rpc/_efs_guardian.py 100.0% <ø> (ø)
.../src/simcore_service_efs_guardian/core/settings.py 97.3% <100.0%> (ø)
...mcore_service_efs_guardian/services/efs_manager.py 100.0% <ø> (ø)
...service_efs_guardian/services/efs_manager_setup.py 96.0% <100.0%> (ø)
..._sidecar/scheduler/_core/_event_create_sidecars.py 52.6% <33.3%> (ø)
...ice_director_v2/modules/dynamic_sidecar/volumes.py 64.0% <60.0%> (ø)
...es/dynamic_sidecar/docker_service_specs/sidecar.py 84.6% <66.6%> (ø)

... and 1361 files with indirect coverage changes

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

@matusdrobuliak66 matusdrobuliak66 requested a review from GitHK June 6, 2024 13:11
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to some feedback, I think you can maybe convince me with some words to accept as-is ;) Thanks!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

services/docker-compose.yml Outdated Show resolved Hide resolved
.env-devel Outdated Show resolved Hide resolved
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for considering my input!

Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sanderegg sanderegg merged commit e10ce2f into ITISFoundation:master Jun 10, 2024
57 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 5, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mount EFS to sidecar
4 participants