Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨E2E Playwright: add extra headers for all requests #5746

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 26, 2024

What do these changes do?

This is needed so that it is easy to filter in prometheus

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Apr 26, 2024
@sanderegg sanderegg added this to the Enchanted Odyssey milestone Apr 26, 2024
@sanderegg sanderegg self-assigned this Apr 26, 2024
@sanderegg sanderegg force-pushed the playwright/add-extra-headers branch from 156241d to 82c9267 Compare April 26, 2024 10:55
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.4%. Comparing base (cafbf96) to head (82c9267).
Report is 155 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5746      +/-   ##
=========================================
- Coverage    84.5%   41.4%   -43.2%     
=========================================
  Files          10     334     +324     
  Lines         214   16244   +16030     
  Branches       25       0      -25     
=========================================
+ Hits          181    6732    +6551     
- Misses         23    9512    +9489     
+ Partials       10       0      -10     
Flag Coverage Δ
integrationtests 41.4% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 344 files with indirect coverage changes

@sanderegg sanderegg merged commit df75228 into ITISFoundation:master Apr 26, 2024
54 of 56 checks passed
@sanderegg sanderegg deleted the playwright/add-extra-headers branch April 26, 2024 11:47
@odeimaiz
Copy link
Member

Merci!

matusdrobuliak66 added a commit to matusdrobuliak66/osparc-simcore that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants