🎨 Enh: Merge secondary column's content

[odeimaiz]

What do these changes do?

Having three tab pages in the secondary columns can make their content to be a bit hidden (specially the Service Options: update version, change boot mode, update resource limits). Since most of the space there was unused, this PR brings all the content to the same page.

Bonus:

• Do not let users delete nodes while pipeline is running.

Content merged (notice the flexible labels):

Disable main Delete Node buttons:

Related issue/s

fixes #5722
fixes ITISFoundation/osparc-issues#1398

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.0%. Comparing base (cafbf96) to head (466fdfe).
Report is 157 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5740      +/-   ##
=========================================
- Coverage    84.5%   53.0%   -31.6%     
=========================================
  Files          10     483     +473     
  Lines         214   24743   +24529     
  Branches       25     205     +180     
=========================================
+ Hits          181   13130   +12949     
- Misses         23   11561   +11538     
- Partials       10      52      +42     

Flag	Coverage Δ
integrationtests	53.0% <ø> (?)
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 493 files with indirect coverage changes

[sanderegg]

that is very nice!!
maybe you could also align the unit with the text?

[elisabettai]

Wow, that's a big change, we're getting rid of the inputs and outputs tab. 🥲
I like the single tab, it helps a lot finding all the useful information in one single place.

Two small questions/suggestions:

1. The icon of the secondary column shows gears, which is also the icon for comp. nodes and it might be confusing. I'd just delete the tab icons, since we don't have tabs anymore.
2. Does the icon at the left of "Inputs", "Outputs", etc... mean that you can collapse it (and hide long lists of inputs/outputs if you want)? In not, I'd remove the icon.
   

[odeimaiz]

@elisabettai

1. The icon of the secondary column shows gears, which is also the icon for comp. nodes and it might be confusing. I'd just delete the tab icons, since we don't have tabs anymore.

When you select the study entry in the tree or the selection is empty, we do show an icon on top. Also, when a file picker is selected it has its own icon. So no icon isn't an option, which icon do you propose?

2. Does the icon at the left of "Inputs", "Outputs", etc... mean that you can collapse it (and hide long lists of inputs/outputs if you want)? In not, I'd remove the icon.

Yes, they are collapsible.

[pcrespov]

fantastic!

[elisabettai]

When you select the study entry in the tree or the selection is empty, we do show an icon on top. Also, when a file picker is selected it has its own icon. So no icon isn't an option, which icon do you propose?

I see what you mean, but also in those cases, I don't find the icons very useful. I think they're useful if there is more than 1 tabs, so users need a way to "activate" the other tabs and recognize the different functionality. So the advantage I see in removing, is that we would clean a bit the UI from elements that we don't need.

But I also understand if you don't want to get rid of them, maybe that would require a lot of code changes for a small improvement. For the icon, I'd use the "input" (or "output") port one or a double arrow (e.g. this).

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[jsaq007]

Looks good.