Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: Add recipient to Sticky notes #5723

Merged
merged 11 commits into from
Apr 24, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 24, 2024

What do these changes do?

Fixed:
AddRecipient

Related issue/s

fixes ITISFoundation/osparc-issues#1282

How to test

Dev-ops checklist

@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Apr 24, 2024
@odeimaiz odeimaiz added this to the Enchanted Odyssey milestone Apr 24, 2024
@odeimaiz odeimaiz self-assigned this Apr 24, 2024
@odeimaiz odeimaiz marked this pull request as ready for review April 24, 2024 12:06
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 , thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Have you considered starting integrating user names e.g. like @odeimaiz
The new users table gurantees uniqueness of usernames

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one...

@odeimaiz
Copy link
Member Author

Nice. Have you considered starting integrating user names e.g. like @odeimaiz The new users table gurantees uniqueness of usernames

@pcrespov does the frontend have access to those unique usernames?

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks a lot

Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz enabled auto-merge (squash) April 24, 2024 14:44
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.1%. Comparing base (cafbf96) to head (1472a1b).
Report is 143 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5723      +/-   ##
=========================================
+ Coverage    84.5%   87.1%    +2.5%     
=========================================
  Files          10    1259    +1249     
  Lines         214   52829   +52615     
  Branches       25     810     +785     
=========================================
+ Hits          181   46056   +45875     
- Misses         23    6603    +6580     
- Partials       10     170     +160     
Flag Coverage Δ
integrationtests 59.6% <ø> (?)
unittests 85.8% <ø> (+1.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1240 files with indirect coverage changes

@odeimaiz odeimaiz merged commit 086df7a into ITISFoundation:master Apr 24, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stick notes: can't add recipient
6 participants