Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up oecs in api server #5719

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Apr 23, 2024

What do these changes do?

  • Ensure OEC is only generated when an unexpected error happens in the api-server

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner April 23, 2024 15:30
@bisgaard-itis bisgaard-itis marked this pull request as draft April 23, 2024 15:30
@bisgaard-itis bisgaard-itis self-assigned this Apr 23, 2024
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label Apr 23, 2024
@bisgaard-itis bisgaard-itis added this to the Enchanted Odyssey milestone Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.3%. Comparing base (cafbf96) to head (93cbde0).
Report is 147 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5719      +/-   ##
=========================================
+ Coverage    84.5%   87.3%    +2.7%     
=========================================
  Files          10    1043    +1033     
  Lines         214   46031   +45817     
  Branches       25     662     +637     
=========================================
+ Hits          181   40204   +40023     
- Misses         23    5675    +5652     
- Partials       10     152     +142     
Flag Coverage Δ
integrationtests 65.1% <ø> (?)
unittests 84.8% <78.5%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ages/service-library/src/servicelib/error_codes.py 84.6% <100.0%> (ø)
...ore_service_api_server/api/errors/custom_errors.py 88.2% <ø> (ø)
...c/simcore_service_api_server/api/routes/solvers.py 65.0% <100.0%> (ø)
...src/simcore_service_api_server/core/application.py 98.7% <ø> (ø)
...imcore_service_api_server/api/errors/http_error.py 95.4% <83.3%> (ø)
..._api_server/services/service_exception_handling.py 82.2% <60.0%> (ø)

... and 1040 files with indirect coverage changes

@bisgaard-itis bisgaard-itis marked this pull request as ready for review April 24, 2024 12:09
@bisgaard-itis bisgaard-itis requested a review from wvangeit April 24, 2024 12:10
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) April 24, 2024 14:45
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks!

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bisgaard-itis bisgaard-itis merged commit 0f4ccf6 into ITISFoundation:master Apr 25, 2024
56 checks passed
@bisgaard-itis bisgaard-itis deleted the 5718-clean-up-oecs-in-api-server branch April 25, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants