Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Image pulling downloaded sizes when available #5712

Merged
merged 6 commits into from
Apr 23, 2024
Merged

🎨 Image pulling downloaded sizes when available #5712

merged 6 commits into from
Apr 23, 2024

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Apr 23, 2024 •
edited
Loading

What do these changes do?

Show the downloaded progress, when available, while the dynamic services boot. If they aren't available show the percentage progress.

2024-04-23 11 32 58

Related issue/s

How to test

Dev-ops checklist

@jsaq007 jsaq007 added a:frontend issue affecting the front-end (area group) UX_improvements UX Feedback during frontend testing process labels Apr 23, 2024
@jsaq007 jsaq007 added this to the Enchanted Odyssey milestone Apr 23, 2024
@jsaq007 jsaq007 self-assigned this Apr 23, 2024
@jsaq007 jsaq007 marked this pull request as ready for review April 23, 2024 09:47
sanderegg
sanderegg approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice! Thanks
One thing though, when you show the pulling of the image with the total size, I would show the 0.0/total, from your gif it looks like only the total is shown?
Also I would try to keep the number of digits constant if possible.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

GitHK
GitHK reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. I see that the total is showing something like 456/11GB which to me reads wrong. could you make sure that the first part is properly converted to GB and it's not in bytes or megabytes?

@jsaq007 jsaq007 merged commit a7a5b98 into ITISFoundation:master Apr 23, 2024
50 checks passed
This was referenced Apr 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK left review comments

@sanderegg sanderegg sanderegg approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@elisabettai elisabettai Awaiting requested review from elisabettai

@mguidon mguidon Awaiting requested review from mguidon

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@jsaq007 jsaq007

Labels
a:frontend issue affecting the front-end (area group) UX_improvements UX Feedback during frontend testing process
Projects
None yet
Milestone
Enchanted Odyssey
Development

Successfully merging this pull request may close these issues.
4 participants
@jsaq007 @GitHK @odeimaiz @sanderegg