-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add captcha to registration form #5698
✨ Add captcha to registration form #5698
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5698 +/- ##
=========================================
- Coverage 84.5% 84.0% -0.6%
=========================================
Files 10 1127 +1117
Lines 214 49968 +49754
Branches 25 555 +530
=========================================
+ Hits 181 41989 +41808
- Misses 23 7858 +7835
- Partials 10 121 +111
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ore into matusdrobuliak66-add-captcha
✨ Frontend: Captcha on Request Account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Added some suggestions on the backend
Regarding the front-end:
- UX: Add some instruction to indicate that clicking the image regenerates the code
- UI: is there a way to make more space and fit the entire form in a single page? e.g. reducing the fonts or increasing the width?
services/web/server/src/simcore_service_webserver/login/_registration_api.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/login/_registration_api.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/login/_registration_api.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/login/_registration_handlers.py
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/auth/ui/RequestAccount.js
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/login/_registration_handlers.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I guess the get_session is per user right? otherwise I was wondering how that would work multi-user.
2nd question, if I make a locust that runs the get /auth/captcha, can I break the webserver by making it use a shitload of memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice to me. some minor things
services/static-webserver/client/source/class/osparc/auth/ui/RequestAccount.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/auth/ui/RequestAccount.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Thanks a lot
|
I added a reload button, with that we avoid adding more text to an already busy form. Regarding the single page, the font is already small, so the only solution I see is to go for a wider and 3 columns form... not a big fun of that solution. Also, this was "designed" by the people on the 3rd floor, so it might trigger more meetings... |
Frontend: reload captcha button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 I just wonder if the image is a little cut off could it cause issue for a user if their resolution is higher?
Quality Gate passedIssues Measures |
What do these changes do?
Related issue/s
How to test
Dev-ops checklist