Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ e2e: Convert puppeteer's ti-plan.js into playwright's ti_plan.py #5689

Merged
merged 27 commits into from
Apr 22, 2024
Merged

✨ e2e: Convert puppeteer's ti-plan.js into playwright's ti_plan.py #5689

merged 27 commits into from
Apr 22, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 17, 2024 •
edited
Loading

What do these changes do?

Added playwright e2e testing for the Classic TI pipeline.

No animation, it takes 6'16"...

image

Related issue/s

related to #5630
related to #5709

How to test

Dev-ops checklist

@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Apr 17, 2024
@odeimaiz odeimaiz added this to the Enchanted Odyssey milestone Apr 17, 2024
@odeimaiz odeimaiz self-assigned this Apr 17, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.9%. Comparing base (cafbf96) to head (5cb4ecd).
Report is 130 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5689      +/-   ##
=========================================
- Coverage    84.5%   64.9%   -19.7%     
=========================================
  Files          10     548     +538     
  Lines         214   27564   +27350     
  Branches       25     204     +179     
=========================================
+ Hits          181   17892   +17711     
- Misses         23    9620    +9597     
- Partials       10      52      +42
Flag Coverage Δ
integrationtests 64.9% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 558 files with indirect coverage changes

@odeimaiz odeimaiz changed the title ✨ e2e: Convert puppeteer's ti-plan.js into playwright's ti-plan.py WIP ✨ e2e: Convert puppeteer's ti-plan.js into playwright's ti-plan.py Apr 17, 2024
@odeimaiz odeimaiz changed the title WIP ✨ e2e: Convert puppeteer's ti-plan.js into playwright's ti-plan.py WIP ✨ e2e: Convert puppeteer's ti-plan.js into playwright's ti_plan.py Apr 19, 2024
@odeimaiz odeimaiz marked this pull request as ready for review April 19, 2024 12:54
@odeimaiz odeimaiz requested a review from ignapas as a code owner April 19, 2024 12:54
@odeimaiz odeimaiz changed the title WIP ✨ e2e: Convert puppeteer's ti-plan.js into playwright's ti_plan.py ✨ e2e: Convert puppeteer's ti-plan.js into playwright's ti_plan.py Apr 19, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) April 19, 2024 14:14
@odeimaiz odeimaiz requested review from oetiker, GitHK, pcrespov, mguidon and sanderegg and removed request for oetiker April 19, 2024 14:14
@odeimaiz odeimaiz disabled auto-merge April 19, 2024 14:38
pcrespov
pcrespov approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx so much!

tests/e2e/tutorials/ti-plan.js Show resolved Hide resolved
@odeimaiz odeimaiz enabled auto-merge (squash) April 19, 2024 15:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

matusdrobuliak66
matusdrobuliak66 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ! :) thanks a lot!

jsaq007
jsaq007 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one... :)

@odeimaiz odeimaiz merged commit dd80ad4 into ITISFoundation:master Apr 22, 2024
56 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 23, 2024
Closed
17 tasks
@odeimaiz odeimaiz mentioned this pull request Apr 23, 2024
Closed
This was referenced Apr 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@GitHK GitHK Awaiting requested review from GitHK

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Enchanted Odyssey
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @jsaq007 @pcrespov @sanderegg @matusdrobuliak66