-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Restores compatibility with deprecated storage API used in legacy services #5679
🐛 Restores compatibility with deprecated storage API used in legacy services #5679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for going back
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5679 +/- ##
=========================================
- Coverage 84.5% 65.0% -19.5%
=========================================
Files 10 555 +545
Lines 214 27905 +27691
Branches 25 204 +179
=========================================
+ Hits 181 18165 +17984
- Misses 23 9688 +9665
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks for taking care of it
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
Some legacy tests fail with
because deprecated client expects
data
field always as an object as can be seen hereosparc-simcore/services/storage/client-sdk/python/simcore_service_storage_sdk/models/file_meta_data_enveloped.py
Lines 33 to 38 in cfdf4f8
Related issue/s
How to test
Dev-ops checklist