Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Restores compatibility with deprecated storage API used in legacy services #5679

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

pcrespov
Copy link
Member

What do these changes do?

Some legacy tests fail with
image

because deprecated client expects data field always as an object as can be seen here

"""
openapi_types = {
'data': 'FileMetaDataType',
'error': 'object'
}

Related issue/s

How to test

Dev-ops checklist

@pcrespov pcrespov self-assigned this Apr 16, 2024
@pcrespov pcrespov added the a:storage issue related to storage service label Apr 16, 2024
@pcrespov pcrespov marked this pull request as ready for review April 16, 2024 09:54
@pcrespov pcrespov requested a review from sanderegg as a code owner April 16, 2024 09:54
@pcrespov pcrespov requested review from GitHK and bisgaard-itis April 16, 2024 09:54
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for going back

@pcrespov pcrespov enabled auto-merge (squash) April 16, 2024 10:04
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.0%. Comparing base (cafbf96) to head (87637bb).
Report is 115 commits behind head on master.

❗ Current head 87637bb differs from pull request most recent head 431a904. Consider uploading reports for the commit 431a904 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5679      +/-   ##
=========================================
- Coverage    84.5%   65.0%   -19.5%     
=========================================
  Files          10     555     +545     
  Lines         214   27905   +27691     
  Branches       25     204     +179     
=========================================
+ Hits          181   18165   +17984     
- Misses         23    9688    +9665     
- Partials       10      52      +42     
Flag Coverage Δ
integrationtests 65.0% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 565 files with indirect coverage changes

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for taking care of it

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov merged commit 03b043e into ITISFoundation:master Apr 16, 2024
51 checks passed
@pcrespov pcrespov deleted the is5676/fix-envelope-legacy branch April 16, 2024 12:21
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Apr 16, 2024
@pcrespov pcrespov added this to the Enchanted Odyssey milestone Apr 25, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 26, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy services fail to start
4 participants