🐛 bugfix: file download

[bisgaard-itis]

What do these changes do?

• The file download is broken in the python osparc client.
• This fixes the openapi.json.

Related issue/s

How to test

• manually generate osparc client and run tests. These changes to the client will be done after this PR is merged.

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.9%. Comparing base (cafbf96) to head (a65a53f).
Report is 114 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5673      +/-   ##
=========================================
- Coverage    84.5%   66.9%   -17.6%     
=========================================
  Files          10     630     +620     
  Lines         214   30856   +30642     
  Branches       25     204     +179     
=========================================
+ Hits          181   20670   +20489     
- Misses         23   10134   +10111     
- Partials       10      52      +42     

Flag	Coverage Δ
integrationtests	65.0% <ø> (?)
unittests	84.9% <ø> (+0.3%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...src/simcore_service_api_server/api/routes/files.py	68.6% <ø> (ø)

... and 635 files with indirect coverage changes

[pcrespov]

Can you add a test that guarantees that this change actually works. Or if that exists, can you please point which test covers this code?

[wvangeit]

Thx. Looks good.

[bisgaard-itis]

Can you add a test that guarantees that this change actually works. Or if that exists, can you please point which test covers this code?

I added a test which ensures that media type of the content is application/octet-stream when the download file endpoint returns status 200. This of course doesn't guarantee that the client call works, but there are e2e tests which checks this (which is how I discovered the bug).

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud