Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Frontend: File Probe UI #5670

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 12, 2024

What do these changes do?

This PR provides a specific frontend for the probe-file. When the file is ready, a link is shown on the node and it can be downloaded/accessed by clicking on it.

FileProbe

Related issue/s

related to ITISFoundation/osparc-issues#1360

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 12, 2024
@odeimaiz odeimaiz changed the title WIP ✨ Frontend: File Probe UI ✨ Frontend: File Probe UI Apr 15, 2024
@odeimaiz odeimaiz marked this pull request as ready for review April 15, 2024 10:35
@odeimaiz odeimaiz enabled auto-merge (squash) April 15, 2024 10:39
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. This feature would allow a richer UX since it canuse the probes to download files from the GUI

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@odeimaiz odeimaiz merged commit b309461 into ITISFoundation:master Apr 15, 2024
50 checks passed
pcrespov pushed a commit to pcrespov/osparc-simcore that referenced this pull request Apr 16, 2024
@pcrespov pcrespov added this to the Enchanted Odyssey milestone Apr 25, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 26, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants