-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Allow using S3 in different region than us-east-1 and S3 settings are not following correct definitions (⚠️ devops) #5667
🐛Allow using S3 in different region than us-east-1 and S3 settings are not following correct definitions (⚠️ devops) #5667
Conversation
1d8421d
to
f4d9a18
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5667 +/- ##
=========================================
+ Coverage 84.5% 87.5% +2.9%
=========================================
Files 10 1362 +1352
Lines 214 56354 +56140
Branches 25 1255 +1230
=========================================
+ Hits 181 49321 +49140
- Misses 23 6761 +6738
- Partials 10 272 +262
Flags with carried forward coverage won't be shown. Click here to find out more.
|
32b335b
to
d772a75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, except te missing validator
925bfe9
to
5acc4c2
Compare
Quality Gate passedIssues Measures |
…e not following correct definitions (ITISFoundation#5667)
What do these changes do?
The S3 settings module is very old and that is an understatement.
Since we are deploying into Oregon, we now face the problem that it is impossible to switch the S3 settings to another region because the S3_ENDPOINT cannot be nullified due to a validator.
This PR removes that validator and removes the default values of S3_REGION which makes changing the region very cumbersome.
Related issue/s
How to test
Dev-ops checklist
S3_REGION
,AGENT_VOLUMES_CLEANUP_S3_REGION
env variable are compulsoryS3_ENDPOINT
andAGENT_VOLUMES_CLEANUP_S3_ENDPOINT
env variable now only accepts http(s) URLsS3_SECURE
,AGENT_VOLUMES_CLEANUP_S3_SECURE
env variablesS3_ACCESS_TOKEN
unused