-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Frontend: Tabbed Windows and Views #5665
Merged
odeimaiz
merged 24 commits into
ITISFoundation:master
from
odeimaiz:refactor/tabbed-window
Apr 15, 2024
Merged
♻️ Frontend: Tabbed Windows and Views #5665
odeimaiz
merged 24 commits into
ITISFoundation:master
from
odeimaiz:refactor/tabbed-window
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
changed the title
WIP ♻️ Frontend: Tabbed Window
♻️ Frontend: Tabbed Windows and Views
Apr 12, 2024
sanderegg
approved these changes
Apr 12, 2024
Please retry analysis of this Pull-Request directly on SonarCloud |
pcrespov
approved these changes
Apr 12, 2024
GitHK
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ignapas
approved these changes
Apr 15, 2024
Quality Gate passedIssues Measures |
matusdrobuliak66
approved these changes
Apr 15, 2024
16 tasks
pcrespov
pushed a commit
to pcrespov/osparc-simcore
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Not much to show here: all the windows (Admin Center, PO Center, My Account, Billing Center, Preferences and Resource Details (study, template, service)) that show tabbed views inherit now from the same base classes.
Related issue/s
How to test
Dev-ops checklist