♻️ Migrate to docker stack config
#5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnicegyu11
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5523 +/- ##
=========================================
+ Coverage 84.5% 86.4% +1.9%
=========================================
Files 10 935 +925
Lines 214 42282 +42068
Branches 25 788 +763
=========================================
+ Hits 181 36567 +36386
- Misses 23 5534 +5511
- Partials 10 181 +171
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
reviewed
Mar 20, 2024
pcrespov
approved these changes
Mar 20, 2024
GitHK
approved these changes
Mar 20, 2024
sanderegg
reviewed
Mar 21, 2024
mrnicegyu11
changed the title
docker stack deploy
mrnicegyu11
changed the title
docker stack deploydocker stack config
mrnicegyu11
changed the title
docker stack configdocker stack config
matusdrobuliak66
approved these changes
Apr 2, 2024
* revert changes * have docker stack config for clarity * replaced docker compose config by docker stack config * replaced docker compose config by docker stack config * fix issue * add a note * delete file * fix note
* remove sed stuff * remove sed * go for info * missing variable * dask stack config does not support nested ENV definitions
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-ops-environments
that referenced
this pull request
Apr 2, 2024
bisgaard-itis
approved these changes
Apr 2, 2024
|
|
test passed, force merged without @sanderegg approval since he gave it yesterday and today he is off |
mrnicegyu11
added a commit
to ITISFoundation/osparc-ops-environments
that referenced
this pull request
Apr 8, 2024
* Revert "Revert "Try to fix CD - 3"" This reverts commit 945b576. * Rename obscure bash scripts * Remove stale comment * add comment * Remove references to env-devel * Fix devenv venv: install typer * Pull docker-stack-config.bash from github.com/ITISFoundation/osparc-simcore/pull/5523 * Fix bug: Remove unused secrets * Handle docker-in-docker situations and docker secrets handling in gitlab Ci runners * Fix bug spotted by @YuryHrytsuk --------- Co-authored-by: kaiser <[email protected]>
14 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
docker configin favor of usingdocker stack config, as recommended by dockerdocker stack composeand results inRelated PRs
ITISFoundation/osparc-ops-environments#613
https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/501#19f9eb849fe8623b5079612f75102c63d695b03e
How to test
Dev-ops checklist