Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Send email on successful payment w/ payment-method #5376

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 26, 2024

What do these changes do?

This PR sends also send an email to the user for a succesful payment using a saved payment method (e.g. when auto-recharge mechanism is enabled).

Highlights

  • NotifierService uses fire&forget to notify
  • pay_with_payment_method incorporates notifier but excludes websocket notifications
  • email notifications currently upon success payment only (not websockets notify also failures)

Related issue/s

How to test

  • Tested in master by payment w/ payment-method
  • Tested in master by payment with auto-recharge
  • Driving tests test_services_payments

Dev Checklist

DevOps Checklist

None

@pcrespov pcrespov self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.3%. Comparing base (c7c69bd) to head (dc74dc7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5376      +/-   ##
=========================================
- Coverage    87.5%   66.3%   -21.2%     
=========================================
  Files        1318     586     -732     
  Lines       54179   28574   -25605     
  Branches     1176     203     -973     
=========================================
- Hits        47412   18963   -28449     
- Misses       6517    9560    +3043     
+ Partials      250      51     -199     
Flag Coverage Δ
integrationtests 65.0% <ø> (-0.1%) ⬇️
unittests 91.6% <91.6%> (+6.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...core_service_payments/api/rpc/_payments_methods.py 100.0% <100.0%> (ø)
...payments/services/auto_recharge_process_message.py 93.7% <100.0%> (-0.2%) ⬇️
.../simcore_service_payments/services/notifier_abc.py 86.6% <100.0%> (+3.3%) ⬆️
...imcore_service_payments/services/notifier_email.py 95.4% <100.0%> (+0.1%) ⬆️
.../src/simcore_service_payments/services/payments.py 95.6% <100.0%> (+1.4%) ⬆️
.../src/simcore_service_payments/services/notifier.py 86.0% <80.0%> (-0.1%) ⬇️

... and 1068 files with indirect coverage changes

@pcrespov pcrespov changed the title WIP: 🎨 Is5227/send on payment w payment method 🎨 Is5227/send on payment w payment method Feb 26, 2024
@pcrespov pcrespov changed the title 🎨 Is5227/send on payment w payment method 🎨 Send email on successful payment w/ payment-method Feb 26, 2024
@pcrespov pcrespov added the a:payments payments service label Feb 26, 2024
@pcrespov pcrespov added this to the Schoggilebe milestone Feb 26, 2024
@pcrespov pcrespov force-pushed the is5227/send-on-payment-w-payment-method branch from da7fa0e to 7c974a8 Compare February 26, 2024 19:21
@pcrespov pcrespov marked this pull request as ready for review February 26, 2024 19:21
@pcrespov pcrespov enabled auto-merge (squash) February 27, 2024 06:34
@pcrespov pcrespov requested a review from GitHK February 27, 2024 06:42
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov merged commit f328a29 into ITISFoundation:master Feb 27, 2024
55 checks passed
@pcrespov pcrespov deleted the is5227/send-on-payment-w-payment-method branch February 27, 2024 09:56
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Feb 27, 2024
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Feb 27, 2024
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:payments payments service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants