-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Send email on successful payment w/ payment-method #5376
🎨 Send email on successful payment w/ payment-method #5376
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5376 +/- ##
=========================================
- Coverage 87.5% 66.3% -21.2%
=========================================
Files 1318 586 -732
Lines 54179 28574 -25605
Branches 1176 203 -973
=========================================
- Hits 47412 18963 -28449
- Misses 6517 9560 +3043
+ Partials 250 51 -199
Flags with carried forward coverage won't be shown. Click here to find out more.
|
da7fa0e
to
7c974a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 👍
Quality Gate passedIssues Measures |
What do these changes do?
This PR sends also send an email to the user for a succesful payment using a saved payment method (e.g. when auto-recharge mechanism is enabled).
Highlights
NotifierService
uses fire&forget to notifypay_with_payment_method
incorporatesnotifier
but excludes websocket notificationsRelated issue/s
How to test
test_services_payments
Dev Checklist
DevOps Checklist
None