🐛 Fix flaky test_disk_usage
#5364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
requested review from
sanderegg,
pcrespov and
matusdrobuliak66
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5364 +/- ##
========================================
+ Coverage 86.8% 87.7% +0.8%
========================================
Files 1187 1095 -92
Lines 49076 48186 -890
Branches 923 553 -370
========================================
- Hits 42643 42290 -353
+ Misses 6236 5775 -461
+ Partials 197 121 -76
Flags with carried forward coverage won't be shown. Click here to find out more. |
matusdrobuliak66
approved these changes
Feb 23, 2024
sanderegg
approved these changes
Feb 23, 2024
21 tasks
jsaq007
pushed a commit
to jsaq007/osparc-simcore
that referenced
this pull request
Feb 27, 2024
Co-authored-by: Andrei Neagu <[email protected]>
jsaq007
pushed a commit
to jsaq007/osparc-simcore
that referenced
this pull request
Mar 4, 2024
Co-authored-by: Andrei Neagu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As usual comparing floats is hard. Done the right way. Added regression tests.
Related issue/s
How to test
Dev Checklist
DevOps Checklist