Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 switch to debugpy #5345

Merged
merged 21 commits into from
Feb 20, 2024
Merged

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Feb 19, 2024

What do these changes do?

  • Switch to using debugpy for debugging local deployment

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@bisgaard-itis bisgaard-itis self-assigned this Feb 19, 2024
@bisgaard-itis bisgaard-itis added the t:maintenance Some planned maintenance work label Feb 19, 2024
@bisgaard-itis bisgaard-itis added this to the Schoggilebe milestone Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dc2a98b) 87.3% compared to head (bbc57ff) 87.4%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5345     +/-   ##
========================================
+ Coverage    87.3%   87.4%   +0.1%     
========================================
  Files        1321    1313      -8     
  Lines       54181   54034    -147     
  Branches     1172    1172             
========================================
- Hits        47321   47268     -53     
+ Misses       6610    6516     -94     
  Partials      250     250             
Flag Coverage Δ
integrationtests 65.0% <83.3%> (-0.1%) ⬇️
unittests 85.3% <90.9%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/models-library/src/models_library/basic_types.py 98.2% <100.0%> (ø)
...ttings-library/src/settings_library/basic_types.py 100.0% <100.0%> (ø)
...src/simcore_service_api_server/core/application.py 98.7% <100.0%> (+1.2%) ⬆️
...er/src/simcore_service_api_server/core/settings.py 91.1% <ø> (-0.2%) ⬇️
...rc/simcore_service_autoscaling/core/application.py 100.0% <ø> (+2.1%) ⬆️
...catalog/src/simcore_service_catalog/core/events.py 100.0% <ø> (ø)
...imcore_service_clusters_keeper/core/application.py 100.0% <ø> (ø)
...src/simcore_service_datcore_adapter/core/events.py 100.0% <100.0%> (ø)
...rc/simcore_service_director_v2/core/application.py 98.6% <ø> (+1.2%) ⬆️
...2/src/simcore_service_director_v2/core/settings.py 100.0% <100.0%> (ø)
... and 7 more

... and 10 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thx so much!
Does the .vscode/launch.template.json need to be updated as well or works as is?

services/docker-compose.local.yml Show resolved Hide resolved
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice thanks!

Copy link

sonarqubecloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) February 20, 2024 13:29
@bisgaard-itis bisgaard-itis merged commit b11a63d into ITISFoundation:master Feb 20, 2024
55 checks passed
@bisgaard-itis bisgaard-itis deleted the 5343-debugpy branch February 20, 2024 13:44
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to debugpy everywhere
5 participants