-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 improve investigate log streaming #5330
🎨 improve investigate log streaming #5330
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5330 +/- ##
=========================================
- Coverage 87.3% 66.6% -20.7%
=========================================
Files 1321 613 -708
Lines 54152 29832 -24320
Branches 1172 202 -970
=========================================
- Hits 47287 19897 -27390
- Misses 6615 9885 +3270
+ Partials 250 50 -200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tuning
services/api-server/src/simcore_service_api_server/services/log_streaming.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services/log_streaming.py
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
What do these changes do?
Related issue/s
How to test
Dev Checklist
DevOps Checklist