Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 improve investigate log streaming #5330

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Feb 13, 2024

What do these changes do?

  • Ensure logstreaming cancels when client disconnects
  • Clean up logic for how to determine when to stop streaming logs

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@bisgaard-itis bisgaard-itis self-assigned this Feb 13, 2024
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label Feb 13, 2024
@bisgaard-itis bisgaard-itis added this to the Schoggilebe milestone Feb 13, 2024
@bisgaard-itis bisgaard-itis marked this pull request as ready for review February 13, 2024 10:54
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (194c626) 87.3% compared to head (1cb9414) 66.6%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5330      +/-   ##
=========================================
- Coverage    87.3%   66.6%   -20.7%     
=========================================
  Files        1321     613     -708     
  Lines       54152   29832   -24320     
  Branches     1172     202     -970     
=========================================
- Hits        47287   19897   -27390     
- Misses       6615    9885    +3270     
+ Partials      250      50     -200     
Flag Coverage Δ
integrationtests 65.0% <ø> (+<0.1%) ⬆️
unittests 83.4% <100.0%> (-1.8%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...re_service_api_server/api/dependencies/rabbitmq.py 86.6% <100.0%> (ø)
...vice_api_server/api/routes/solvers_jobs_getters.py 92.7% <100.0%> (+<0.1%) ⬆️
...er/src/simcore_service_api_server/core/settings.py 91.2% <100.0%> (ø)
...mcore_service_api_server/services/log_streaming.py 90.9% <100.0%> (-0.3%) ⬇️

... and 1043 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tuning

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) February 13, 2024 12:56
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bisgaard-itis bisgaard-itis merged commit 3c2ef61 into ITISFoundation:master Feb 13, 2024
55 checks passed
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants