Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade to pip~=24.0 #5320

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 8, 2024

What do these changes do?

PytestCollectionWarning: cannot collect test class 'TestFailed' because it has a __init__ constructor (from: tests/unit/with_dbs/03/test_email.py)
    class TestFailed(BaseModel):

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@pcrespov pcrespov self-assigned this Feb 8, 2024
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4bfdd6c) 87.3% compared to head (94bd0c2) 87.5%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5320     +/-   ##
========================================
+ Coverage    87.3%   87.5%   +0.2%     
========================================
  Files        1317    1174    -143     
  Lines       53935   49571   -4364     
  Branches     1174     684    -490     
========================================
- Hits        47088   43410   -3678     
+ Misses       6596    6014    -582     
+ Partials      251     147    -104     
Flag Coverage Δ
integrationtests 65.1% <100.0%> (+<0.1%) ⬆️
unittests 85.2% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...r/src/simcore_service_webserver/email/_handlers.py 91.6% <100.0%> (ø)

... and 149 files with indirect coverage changes

PytestCollectionWarning: cannot collect test class 'TestFailed' because it has a __init__ constructor (from: tests/unit/with_dbs/03/test_email.py)
    class TestFailed(BaseModel):
@pcrespov pcrespov enabled auto-merge (squash) February 8, 2024 21:00
@pcrespov pcrespov requested a review from wvangeit February 8, 2024 21:00
@pcrespov pcrespov added this to the Schoggilebe milestone Feb 8, 2024
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks a lot.

@pcrespov pcrespov disabled auto-merge February 9, 2024 12:40
@pcrespov pcrespov merged commit a284681 into ITISFoundation:master Feb 9, 2024
55 checks passed
@pcrespov pcrespov deleted the maintenance/pip-upgrade branch February 9, 2024 12:40
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants