🎨 Add extra tests for no registered subscriber when using RabbitMQClient.subscribe
#5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2024 16:03
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5318 +/- ##
========================================
- Coverage 87.2% 82.1% -5.2%
========================================
Files 1317 1049 -268
Lines 53935 45225 -8710
Branches 1174 611 -563
========================================
- Hits 47083 37162 -9921
- Misses 6601 7920 +1319
+ Partials 251 143 -108
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
changed the title
RabbitMQClient.subscribe
pcrespov
approved these changes
Feb 8, 2024
matusdrobuliak66
approved these changes
Feb 9, 2024
|
jsaq007
pushed a commit
to jsaq007/osparc-simcore
that referenced
this pull request
Feb 22, 2024
…ient.subscribe` (ITISFoundation#5318) Co-authored-by: Andrei Neagu <[email protected]>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
There was a double that having no subscribers attached could send the message in an infinite loop between the delay queue and the main queue. This does not happen.
Related issue/s
How to test
Dev Checklist
DevOps Checklist