Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Fixes flaky test_studies_dispatcher_studies_access #5304

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 6, 2024

What do these changes do?

This PR aims to remove a recent "flaky" test in master

FAILED tests/unit/with_dbs/01/studies_dispatcher/test_studies_dispatcher_studies_access.py::test_guest_user_is_not_garbage_collected[64] - AssertionError: Expected /study/uuid, got /error?message=We+have+reached+the+maximum+of+anonymous+users+allowed+the+platform.+Please+try+later+or+login+with+a+registered+account.&status_code=429

It enhances error handling and cleanup during creation of guest users in the studies_dispatcher plugin.

Related issue/s

Part of

How to test

Dev Checklist

DevOps Checklist

None

@pcrespov pcrespov self-assigned this Feb 6, 2024
@pcrespov pcrespov added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Feb 6, 2024
@pcrespov pcrespov added this to the This is Sparta! milestone Feb 6, 2024
@pcrespov pcrespov force-pushed the maintenance/fix-flaky-anonymous-users branch from d21a3d0 to 235da74 Compare February 6, 2024 10:32
@pcrespov pcrespov enabled auto-merge (squash) February 6, 2024 10:36
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a145762) 85.3% compared to head (7b5e7aa) 81.1%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5304      +/-   ##
=========================================
- Coverage    85.3%   81.1%    -4.3%     
=========================================
  Files        1316     542     -774     
  Lines       53846   27162   -26684     
  Branches     1173     202     -971     
=========================================
- Hits        45973   22044   -23929     
+ Misses       7623    5068    -2555     
+ Partials      250      50     -200     
Flag Coverage Δ
integrationtests 65.1% <30.4%> (+<0.1%) ⬆️
unittests 86.5% <65.2%> (+3.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...re_service_webserver/studies_dispatcher/_errors.py 100.0% <100.0%> (ø)
...ce_webserver/studies_dispatcher/_studies_access.py 85.9% <50.0%> (+56.7%) ⬆️
...ore_service_webserver/studies_dispatcher/_users.py 91.3% <63.1%> (+44.2%) ⬆️

... and 955 files with indirect coverage changes

Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov merged commit 8e4ba9e into ITISFoundation:master Feb 6, 2024
55 checks passed
@pcrespov pcrespov deleted the maintenance/fix-flaky-anonymous-users branch February 6, 2024 12:56
@jsaq007
Copy link
Contributor

jsaq007 commented Feb 7, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants