Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨Maintenance: add dask security to clusters maintenance script #5288

Merged
merged 4 commits into from
Feb 1, 2024
Merged

🎨Maintenance: add dask security to clusters maintenance script #5288

merged 4 commits into from
Feb 1, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 31, 2024 •
edited
Loading

What do these changes do?

  • Enhance the osparc_clusters.py script to be compatible with the newly added dask certificates
  • also computes the remaining disk space on the /docker partition for dynamic autoscaled EC2s
  • simplify the usage of the script by just pointing to the deploy-config location in the osparc-ops-deployment-configuration/deployments/

image

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg self-assigned this Jan 31, 2024
@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Jan 31, 2024
@sanderegg sanderegg added this to the This is Sparta! milestone Jan 31, 2024
@sanderegg sanderegg force-pushed the maintenance/add-security branch from c57b0ec to feef2cb Compare February 1, 2024 09:25
@sanderegg sanderegg marked this pull request as ready for review February 1, 2024 09:25
pcrespov
pcrespov approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are creating quite an amazing toolkit!
Added some thoughts/suggestions

scripts/maintenance/computational-clusters/osparc_clusters.py Show resolved Hide resolved
scripts/maintenance/computational-clusters/osparc_clusters.py Outdated Show resolved Hide resolved
scripts/maintenance/computational-clusters/osparc_clusters.py Outdated Show resolved Hide resolved
scripts/maintenance/computational-clusters/osparc_clusters.py Show resolved Hide resolved
scripts/maintenance/computational-clusters/osparc_clusters.py Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sanderegg sanderegg merged commit 7821b90 into ITISFoundation:master Feb 1, 2024
50 checks passed
@sanderegg sanderegg deleted the maintenance/add-security branch February 1, 2024 12:33
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 7, 2024
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@mguidon mguidon Awaiting requested review from mguidon

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanderegg @GitHK @pcrespov