-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Emit proper product name on socketio connection #5285
🎨 Emit proper product name on socketio connection #5285
Conversation
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5285 +/- ##
=========================================
- Coverage 87.3% 80.8% -6.5%
=========================================
Files 1316 542 -774
Lines 53813 27145 -26668
Branches 1170 202 -968
=========================================
- Hits 46994 21950 -25044
+ Misses 6570 5145 -1425
+ Partials 249 50 -199
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thx!
TIP: rebasing makes the history more readable ;-)
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What do these changes do?
(removed hardcoded
s4l
product)Related issue/s
How to test
Dev Checklist
DevOps Checklist