Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Emit proper product name on socketio connection #5285

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jan 30, 2024

What do these changes do?

  • 🎨 Emit proper product name on socketio connection
    (removed hardcoded s4l product)

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 30 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review January 30, 2024 16:02
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jan 30, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the This is Sparta! milestone Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6706f0f) 87.3% compared to head (b81b6b2) 80.8%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5285      +/-   ##
=========================================
- Coverage    87.3%   80.8%    -6.5%     
=========================================
  Files        1316     542     -774     
  Lines       53813   27145   -26668     
  Branches     1170     202     -968     
=========================================
- Hits        46994   21950   -25044     
+ Misses       6570    5145    -1425     
+ Partials      249      50     -199     
Flag Coverage Δ
integrationtests 63.7% <100.0%> (-1.5%) ⬇️
unittests 86.6% <100.0%> (+1.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/simcore_service_webserver/socketio/_handlers.py 86.0% <100.0%> (+0.5%) ⬆️

... and 905 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thx!

TIP: rebasing makes the history more readable ;-)

@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jan 30, 2024
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) January 31, 2024 09:38
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 merged commit ffc15b7 into ITISFoundation:master Jan 31, 2024
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include product name in request state after @login_required
4 participants