-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Adds new Redis database #5278
✨Adds new Redis database #5278
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5278 +/- ##
=========================================
- Coverage 87.2% 77.7% -9.6%
=========================================
Files 1308 631 -677
Lines 53564 29501 -24063
Branches 1170 237 -933
=========================================
- Hits 46751 22941 -23810
+ Misses 6564 6510 -54
+ Partials 249 50 -199
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everytime we add a new db in redis I ask the same question ;-) ... are we sure that adding a separate db for each feature is correct way?
I have replied to this in my PR. But in this case it's OK. We don't do it on each feature. For some applications it's better to have separate DBs. |
What do these changes do?
In preparation for #5212
I have already merged ITISFoundation/osparc-ops-environments#501 which requires Redis to start one extra db. This will fix redis commander on master.
Related issue/s
How to test
Dev Checklist
DevOps Checklist