Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Adds new Redis database #5278

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 29, 2024

What do these changes do?

In preparation for #5212
I have already merged ITISFoundation/osparc-ops-environments#501 which requires Redis to start one extra db. This will fix redis commander on master.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK changed the title Add redis new database ✨Adds new Redis database Jan 29, 2024
@GitHK GitHK self-assigned this Jan 29, 2024
@GitHK GitHK added this to the This is Sparta! milestone Jan 29, 2024
@GitHK GitHK marked this pull request as ready for review January 29, 2024 09:50
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f37c43) 87.2% compared to head (7c2c6d1) 77.7%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5278      +/-   ##
=========================================
- Coverage    87.2%   77.7%    -9.6%     
=========================================
  Files        1308     631     -677     
  Lines       53564   29501   -24063     
  Branches     1170     237     -933     
=========================================
- Hits        46751   22941   -23810     
+ Misses       6564    6510      -54     
+ Partials      249      50     -199     
Flag Coverage Δ
integrationtests 63.8% <ø> (-1.4%) ⬇️
unittests 80.4% <ø> (-4.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 868 files with indirect coverage changes

@GitHK GitHK enabled auto-merge (squash) January 29, 2024 09:59
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everytime we add a new db in redis I ask the same question ;-) ... are we sure that adding a separate db for each feature is correct way?

@GitHK GitHK merged commit 9a2bcd4 into ITISFoundation:master Jan 29, 2024
54 checks passed
@GitHK GitHK deleted the pr-osparc-redsis-8-dbs branch January 29, 2024 10:18
@GitHK
Copy link
Contributor Author

GitHK commented Jan 29, 2024

Everytime we add a new db in redis I ask the same question ;-) ... are we sure that adding a separate db for each feature is correct way?

I have replied to this in my PR. But in this case it's OK. We don't do it on each feature. For some applications it's better to have separate DBs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants