Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Is922/adding filtering fields to usage endpoint #5277

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jan 29, 2024

What do these changes do?

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 30 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jan 29, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the This is Sparta! milestone Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b6562e) 80.4% compared to head (c23ddfc) 76.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5277      +/-   ##
=========================================
- Coverage    80.4%   76.0%    -4.5%     
=========================================
  Files        1265     536     -729     
  Lines       52322   26980   -25342     
  Branches     1170     202     -968     
=========================================
- Hits        42110   20514   -21596     
+ Misses       9970    6416    -3554     
+ Partials      242      50     -192     
Flag Coverage Δ
integrationtests 71.6% <ø> (+13.1%) ⬆️
unittests 79.3% <83.3%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...vice_webserver/resource_usage/_service_runs_api.py 100.0% <ø> (+48.1%) ⬆️
...webserver/resource_usage/_service_runs_handlers.py 97.2% <83.3%> (+20.1%) ⬆️

... and 1056 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review January 29, 2024 06:59
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check these defaults

api/specs/web-server/_resource_usage.py Outdated Show resolved Hide resolved
api/specs/web-server/_resource_usage.py Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) January 29, 2024 16:10
@matusdrobuliak66 matusdrobuliak66 merged commit 125ca14 into ITISFoundation:master Jan 29, 2024
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants