🐛Fixes TypeError: issubclass() arg 1 must be a class while building BaseCustomSettings classes

[pcrespov]

What do these changes do?

Some configurations with BaseCustomSettings subclasses raised TypeError: issubclass() arg 1 must be a class.

This is raised by issubclass when using pydantic subclasses (e.g. BaseCustomSettings inherits from BaseSettings) in combination with "composed" types as dict[str, str].

>>> issubclass(dict[str, str], dict)
False
 >> issubclass(dict[str, str], BaseSettings)
    Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/home/crespo/.pyenv/versions/3.10.13/lib/python3.10/abc.py", line 123, in __subclasscheck__
        return _abc_subclasscheck(cls, subclass)
    TypeError: issubclass() arg 1 must be a class

Some more information and references to pydantic issues are provided in the code's tests

Related issue/s

How to test

Tests that reproduces the bug in

cd packages/settings-library
pytest -vv -k test_issubclass_type_error_with_pydantic_models

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps Checklist

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (12fd547) 87.6% compared to head (40b6832) 87.1%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5253      +/-   ##
=========================================
- Coverage    87.6%   87.1%    -0.5%     
=========================================
  Files         930    1302     +372     
  Lines       38953   53229   +14276     
  Branches      775    1168     +393     
=========================================
+ Hits        34134   46409   +12275     
- Misses       4650    6570    +1920     
- Partials      169     250      +81     

Flag	Coverage Δ
integrationtests	63.6% <ø> (-1.5%)	⬇️
unittests	85.1% <57.1%> (-0.5%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ages/settings-library/src/settings_library/base.py	89.2% <57.1%> (ø)

... and 395 files with indirect coverage changes

[GitHK]

🎉 thanks a lot!

[bisgaard-itis]

Cool! Thanks!

[sanderegg]

thanks. not sure I get the point with the EnvVarsList becoming an iterable though. but all good.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud