Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fixes expiration date field #5243

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 17, 2024

What do these changes do?

Front-end does not handles properly null expirationDate in /me response payload and displays

image

leading to an unstable state (will be addressed #5244)
In this PR we drop expirationDate in the response when is null. This should solve the problem until the front-end handles null properly

Related issue/s

How to test

Dev Checklist

DevOps

@pcrespov pcrespov self-assigned this Jan 17, 2024
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jan 17, 2024
@pcrespov pcrespov added this to the This is Sparta! milestone Jan 17, 2024
@pcrespov pcrespov changed the title 🐛 fixes expiration date 🐛 fixes expiration date field Jan 17, 2024
@pcrespov pcrespov marked this pull request as ready for review January 17, 2024 09:43
@pcrespov pcrespov requested a review from mguidon January 17, 2024 09:44
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dc7040) 87.3% compared to head (7d81230) 81.2%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5243      +/-   ##
=========================================
- Coverage    87.3%   81.2%    -6.2%     
=========================================
  Files        1295     535     -760     
  Lines       53095   26897   -26198     
  Branches     1164     202     -962     
=========================================
- Hits        46377   21847   -24530     
+ Misses       6468    5000    -1468     
+ Partials      250      50     -200     
Flag Coverage Δ
integrationtests 65.0% <0.0%> (-0.1%) ⬇️
unittests 86.5% <100.0%> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../server/src/simcore_service_webserver/users/api.py 95.6% <100.0%> (+0.1%) ⬆️

... and 879 files with indirect coverage changes

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov enabled auto-merge (squash) January 17, 2024 10:06
@pcrespov pcrespov merged commit e8a68ac into ITISFoundation:master Jan 17, 2024
55 checks passed
@pcrespov pcrespov deleted the fix/rm-expiration-if-none branch January 17, 2024 10:41
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants