-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fixes expiration date field #5243
🐛 fixes expiration date field #5243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5243 +/- ##
=========================================
- Coverage 87.3% 81.2% -6.2%
=========================================
Files 1295 535 -760
Lines 53095 26897 -26198
Branches 1164 202 -962
=========================================
- Hits 46377 21847 -24530
+ Misses 6468 5000 -1468
+ Partials 250 50 -200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What do these changes do?
Front-end does not handles properly null expirationDate in /me response payload and displays
leading to an unstable state (will be addressed #5244)
In this PR we drop
expirationDate
in the response when isnull
. This should solve the problem until the front-end handlesnull
properlyRelated issue/s
How to test
Dev Checklist
DevOps