Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Enhances release monitor script #5242

Merged
merged 12 commits into from
Jan 24, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 16, 2024

What do these changes do?

First round of enhancements on the release-monitor script. The main goal is to move from a custom .env file to a repo.config file as inputs. The latter are curated env files in the osparc-config repo and each deploy has its own.

This is an initial PR that does not change the original functionality but rather defines a new ReleaseSettings to test the new concept before removing the legacy.

Highlights

  1. Enhances CLI: uses commands instead of action options and improve checks on path
  2. Moves code release/monitor to release
  3. New command to display parsed and validated settings

Suggestion

I would like to use a shorter program name. Since this is about MOnitoring Osparc Deploy .. I was wondering something like mood. Then it would read as

mood settings ls
mood --env-file=.env sidecars ls

What do you think?

Related issue/s

Maintenance

How to test

Install

cd scripts/release
make devenv
monitor-release --help

Create a link or pass a path to any of the repo.config (note that by doing that you are already selecting the deploy that your are targeting)

ln -s /path/to/osparc-config-repo/deployments/osparc-master.speag.com/repo.config

List settings

monitor-release settings

will display loaded settings

Dev Checklist

DevOps Checklist

@pcrespov pcrespov self-assigned this Jan 16, 2024
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jan 16, 2024
@pcrespov pcrespov added this to the This is Sparta! milestone Jan 16, 2024
@pcrespov pcrespov force-pushed the maintenance/release-monitor branch from 752afad to 587c728 Compare January 22, 2024 10:15
@pcrespov pcrespov force-pushed the maintenance/release-monitor branch from 587c728 to cf21079 Compare January 24, 2024 14:19
@pcrespov pcrespov changed the title WIP: Maintenance/release monitor 🔨 Enhances release monitor script Jan 24, 2024
@pcrespov pcrespov marked this pull request as ready for review January 24, 2024 14:30
@pcrespov pcrespov requested a review from sanderegg as a code owner January 24, 2024 14:30
@pcrespov pcrespov enabled auto-merge (squash) January 24, 2024 14:38
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the improvements! Regarding your question about 'mood,' I am not a big fan of shortcuts. In one of the large companies, I think Tesla, they even prohibited the use of shortcuts company-wide. One of the reasons is that when you do not use them for two months, it becomes challenging to remember what 'mood' stands for. Another argument is that newcomers always have a hard time with a lot of shortcuts.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Thanks 👍

scripts/release/README.md Outdated Show resolved Hide resolved
scripts/release/README.md Show resolved Hide resolved
scripts/release/monitor_release/settings.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov merged commit c20fb40 into ITISFoundation:master Jan 24, 2024
50 checks passed
@pcrespov pcrespov deleted the maintenance/release-monitor branch January 24, 2024 19:57
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants