-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Enhances release monitor script #5242
🔨 Enhances release monitor script #5242
Conversation
752afad
to
587c728
Compare
587c728
to
cf21079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for the improvements! Regarding your question about 'mood,' I am not a big fan of shortcuts. In one of the large companies, I think Tesla, they even prohibited the use of shortcuts company-wide. One of the reasons is that when you do not use them for two months, it becomes challenging to remember what 'mood' stands for. Another argument is that newcomers always have a hard time with a lot of shortcuts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Thanks 👍
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What do these changes do?
First round of enhancements on the
release-monitor
script. The main goal is to move from a custom.env
file to arepo.config
file as inputs. The latter are curated env files in theosparc-config
repo and each deploy has its own.This is an initial PR that does not change the original functionality but rather defines a new
ReleaseSettings
to test the new concept before removing the legacy.Highlights
action
options and improve checks on pathrelease/monitor
torelease
Suggestion
I would like to use a shorter program name. Since this is about MOnitoring Osparc Deploy .. I was wondering something like
mood
. Then it would read asWhat do you think?
Related issue/s
Maintenance
How to test
Install
Create a link or pass a path to any of the
repo.config
(note that by doing that you are already selecting thedeploy
that your are targeting)List settings
will display loaded settings
Dev Checklist
DevOps Checklist