Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bumping timeouts #5232

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 12, 2024

What do these changes do?

Base timeouts for getting the status and creating a service was 10 seconds instead of the original 20 seconds.
Restored them back to the previous intended threshold.

This was causing requests to timeout faster than expected in the webserver.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Jan 12, 2024
@GitHK GitHK added a:dynamic-scheduler a:webserver issue related to the webserver service labels Jan 12, 2024
@GitHK GitHK added this to the This is Sparta! milestone Jan 12, 2024
@GitHK GitHK marked this pull request as ready for review January 12, 2024 15:00
@GitHK GitHK requested a review from pcrespov as a code owner January 12, 2024 15:00
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e8a68ac) 57.0% compared to head (32e7ecf) 84.2%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5232      +/-   ##
=========================================
+ Coverage    57.0%   84.2%   +27.1%     
=========================================
  Files         518    1035     +517     
  Lines       24016   44578   +20562     
  Branches       11     607     +596     
=========================================
+ Hits        13701   37545   +23844     
+ Misses      10315    6892    -3423     
- Partials        0     141     +141     
Flag Coverage Δ
integrationtests 63.6% <0.0%> (+21.9%) ⬆️
unittests 81.7% <50.0%> (-2.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-v2/src/simcore_service_director_v2/cli/_client.py 100.0% <100.0%> (ø)
...tor_v2/modules/dynamic_sidecar/api_client/_thin.py 100.0% <ø> (+1.5%) ⬆️
...mic_scheduler/services/director_v2/_thin_client.py 100.0% <100.0%> (ø)
...library/src/servicelib/fastapi/http_client_thin.py 89.5% <33.3%> (ø)
...bitmq/rpc_interfaces/dynamic_scheduler/services.py 0.0% <0.0%> (ø)

... and 802 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good. just maybe give a thought on my comment if possible. thanks!

Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GitHK GitHK requested a review from pcrespov January 17, 2024 13:48
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@GitHK GitHK merged commit 3f3d421 into ITISFoundation:master Jan 17, 2024
55 checks passed
@GitHK GitHK deleted the pr-osparc-raise-timeouts-for-rpc-interface branch January 17, 2024 14:25
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-scheduler a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants