-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bumping timeouts #5232
🐛 Bumping timeouts #5232
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5232 +/- ##
=========================================
+ Coverage 57.0% 84.2% +27.1%
=========================================
Files 518 1035 +517
Lines 24016 44578 +20562
Branches 11 607 +596
=========================================
+ Hits 13701 37545 +23844
+ Misses 10315 6892 -3423
- Partials 0 141 +141
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/director_v2/_thin_client.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_scheduler/services.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good. just maybe give a thought on my comment if possible. thanks!
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_scheduler/services.py
Outdated
Show resolved
Hide resolved
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
What do these changes do?
Base timeouts for getting the status and creating a service was 10 seconds instead of the original 20 seconds.
Restored them back to the previous intended threshold.
This was causing requests to timeout faster than expected in the webserver.
Related issue/s
How to test
Dev Checklist
DevOps Checklist