Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ docker compose reads compose spec file from stdin #5231

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 12, 2024

What do these changes do?

This is a drop-in change.

When the user's disk space is exhausted, the dynamic-sidecar, could no longer run any docker compose commands since each time a command was run, a temporary file was created.

Changed the docker compose to read the content of the file from stdin.

BONUS:

  • ♻️ minor refactor to make commands more readable

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Jan 12, 2024
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label Jan 12, 2024
@GitHK GitHK added this to the This is Sparta! milestone Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (146e3ec) 87.3% compared to head (59603a5) 67.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5231      +/-   ##
=========================================
- Coverage    87.3%   67.0%   -20.3%     
=========================================
  Files        1302     535     -767     
  Lines       53216   26875   -26341     
  Branches     1168     202     -966     
=========================================
- Hits        46481   18032   -28449     
- Misses       6485    8793    +2308     
+ Partials      250      50     -200     
Flag Coverage Δ
integrationtests 63.7% <30.4%> (-1.4%) ⬇️
unittests 87.6% <100.0%> (+2.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rvice_dynamic_sidecar/core/docker_compose_utils.py 94.8% <100.0%> (-0.1%) ⬇️
.../src/simcore_service_dynamic_sidecar/core/utils.py 85.0% <100.0%> (-1.2%) ⬇️

... and 1070 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review January 12, 2024 14:56
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but please adjust the names at least, they do not convey what is happening if I get that correctly.

@GitHK GitHK requested review from pcrespov and sanderegg January 17, 2024 15:14
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Added an extra suggestion

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looking much better.

@GitHK GitHK enabled auto-merge (squash) January 18, 2024 06:53
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GitHK GitHK merged commit 7fe457d into ITISFoundation:master Jan 18, 2024
55 checks passed
@GitHK GitHK deleted the pr-osparc-docker-compose-from-stdin branch January 18, 2024 07:22
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants