-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ docker compose reads compose spec file from stdin #5231
♻️ docker compose reads compose spec file from stdin #5231
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5231 +/- ##
=========================================
- Coverage 87.3% 67.0% -20.3%
=========================================
Files 1302 535 -767
Lines 53216 26875 -26341
Branches 1168 202 -966
=========================================
- Hits 46481 18032 -28449
- Misses 6485 8793 +2308
+ Partials 250 50 -200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but please adjust the names at least, they do not convey what is happening if I get that correctly.
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/utils.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_compose_utils.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_compose_utils.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_compose_utils.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_compose_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. Added an extra suggestion
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_compose_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looking much better.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What do these changes do?
This is a drop-in change.
When the user's disk space is exhausted, the dynamic-sidecar, could no longer run any
docker compose
commands since each time a command was run, a temporary file was created.Changed the
docker compose
to read the content of the file fromstdin
.BONUS:
Related issue/s
How to test
Dev Checklist
DevOps Checklist