🐛 webserver now replies with unknown service state

[GitHK]

What do these changes do?

If the dynamic-scheduler raises an error, while the webserver is asking for the service state, the frontend will receive an unknown state.

Upon receiving an unknown state the fronted will try again to fetch the state. At the moment this seems like the safest action to take. In the future, when the service state will be totally driven by the frontend, no further action will be required.

Bonus:

• fixed opsenapi specs for the webserver
• 🎨 better log messages upon RPC error in both the caller and the responder

Related issue/s

• Service idle after "Starting" osparc-issues#1225

How to test

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps Checklist

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7fe457d) 87.3% compared to head (1a314d7) 87.2%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #5230     +/-   ##
========================================
- Coverage    87.3%   87.2%   -0.2%     
========================================
  Files        1302    1186    -116     
  Lines       53208   50797   -2411     
  Branches     1168     954    -214     
========================================
- Hits        46474   44302   -2172     
+ Misses       6484    6282    -202     
+ Partials      250     213     -37     

Flag	Coverage Δ
integrationtests	65.0% <40.0%> (-0.1%)	⬇️
unittests	84.9% <91.3%> (-0.3%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...service-library/src/servicelib/rabbitmq/_errors.py	100.0% <100.0%> (ø)
...ice-library/src/servicelib/rabbitmq/_rpc_router.py	86.0% <ø> (ø)
...c_scheduler/services/director_v2/_public_client.py	92.0% <100.0%> (ø)
...simcore_service_webserver/dynamic_scheduler/api.py	88.0% <100.0%> (+1.9%)	⬆️
...core_service_webserver/projects/_nodes_handlers.py	94.8% <100.0%> (ø)
...ls_library/api_schemas_webserver/projects_nodes.py	96.1% <81.8%> (-3.9%)	⬇️

... and 121 files with indirect coverage changes

[sanderegg]

looking good. please check my comments. Thanks!

[matusdrobuliak66]

👍

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud