🎨 Extends user table with username and first/second name for a user 🗃️

[pcrespov]

What do these changes do?

Enhances users table by adding first/last name (previously encoded in name column) and reuses name to implement a proper "user name"'s unique identifier.

• The username is intended to be used e.g. as in github to refer other users (e.g. @pcrespov) and in the session cookies
• The first/last names will be used to address the user in communication templates (e.g emails/invoices/reports etc)
• ♻️ Adapted login functionality (will be further decoupled in separate PRs)

Related issue/s

• Implements Extend users table with optional address, first_name, last_name and proper user_name #5138
• Closes Add username #1574

How to test

• Driving test packages/postgres-database/tests/test_users.py
• Migration tested against master pg dataset

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps Checklist

• 🗃️ users table is modified

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (942bd7f) 87.4% compared to head (4243913) 87.2%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #5229     +/-   ##
========================================
- Coverage    87.4%   87.2%   -0.2%     
========================================
  Files        1295    1295             
  Lines       53068   53066      -2     
  Branches     1162    1164      +2     
========================================
- Hits        46382   46299     -83     
- Misses       6436    6517     +81     
  Partials      250     250             

Flag	Coverage Δ
integrationtests	63.7% <66.1%> (-1.3%)	⬇️
unittests	85.2% <97.6%> (-0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...dels-library/src/models_library/projects_access.py	96.5% <100.0%> (+0.1%)	⬆️
...ackages/models-library/src/models_library/users.py	100.0% <100.0%> (ø)
...base/src/simcore_postgres_database/models/users.py	93.5% <100.0%> (-0.6%)	⬇️
...vice_api_server/api/dependencies/authentication.py	81.8% <100.0%> (ø)
...src/simcore_service_api_server/api/routes/users.py	100.0% <100.0%> (ø)
...imcore_service_api_server/db/repositories/users.py	100.0% <100.0%> (ø)
...core_service_api_server/models/schemas/profiles.py	96.9% <100.0%> (ø)
...rc/simcore_service_webserver/exporter/_handlers.py	95.1% <100.0%> (ø)
...ver/src/simcore_service_webserver/groups/_users.py	100.0% <100.0%> (ø)
...server/src/simcore_service_webserver/login/_2fa.py	84.4% <ø> (-0.2%)	⬇️
... and 15 more

... and 10 files with indirect coverage changes

[elisabettai]

Very nice! 🎉 Looking forward to seeing it in action.
A question/suggestion on how sharing can be improved thanks to this PR. Probably the following is more related to frontend part.

• when user A wants to share something with user B he sees the weird usernames (created from the email) we have now in the DB. Will it be possible to have here the Name Surname?
  

Edit: @pcrespov maybe you can link this issue as well: ITISFoundation/osparc-issues#1193

[sanderegg]

great thanks!

[pcrespov]

• when user A wants to share something with user B he sees the weird usernames (created from the email) we have now in the DB. Will it be possible to have here the Name Surname?

@elisabettai the problem we had until now is that we did not have a proper "username" concept but rather a composition of "guessed" first and last name. Only if the user would update its profile it would show in there. I mean

This PR makes a clean separation and therefore, yes we could use either username or First+Last name in this list. I would suggest to do like github and other online tools where usernames are the default reference. Moreover in notes we can create automatically references by adding @ as in @elisabettai.

The problem with ITISFoundation/osparc-issues#1193 is that upon registration we do not know the first and last name of the user. I will add a separate PR to somehow get that info from the invitation but when the product has no required invitation the only option is to require it during registration

[GitHK]

Thanks for the changes 👍

[matusdrobuliak66]

Thanks!

[matusdrobuliak66]

👍

[bisgaard-itis]

Very cool! Added a few suggestions and questions. Sorry for the slow review.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[elisabettai]

Hi @pcrespov,
I have two questions on this PR and this comment:

The problem with ITISFoundation/osparc-issues#1193 is that upon registration we do not know the first and last name of the user. I will add a separate PR to somehow get that info from the invitation but when the product has no required invitation the only option is to require it during registration

In sim4life.io (a product with invitation and where First Name and Last Name are mandatory):

1. Will new users have their First Name and Last Name added to the DB?
2. Can then First Name and Last Name, if available, used in the UI (e.g. in default wallet name and welcome message as mentioned in Improve default user name osparc-issues#1193)?