-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 reroute dynamic service stop via dynamic-scheduler
#5192
🎨 reroute dynamic service stop via dynamic-scheduler
#5192
Conversation
…ia-dynamic-scheduler
…ia-dynamic-scheduler
…ia-dynamic-scheduler
…ia-dynamic-scheduler
…t-service-stop-via-dynamic-scheduler
…t-service-stop-via-dynamic-scheduler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks!
Q: why the naming: _thin_client? what is meant by the "thin"? thanks
The |
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_scheduler/errors.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_scheduler/errors.py
Outdated
Show resolved
Hide resolved
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you link the ENV PR from osparc-config
repo?
@YuryHrytsuk added in the PR body above. After it's review and merge I will proceed in merging this PR |
What do these changes do?
Reroute the stop command for dynamic services via the
dynamic-scheduler
.BONUS:
RPCServerError
now properly transfers the traceback instead of just the error name. This helps trace where the error originated (see below)To check before merging
DYNAMIC_SCHEDULER_STOP_SERVICE_TIMEOUT
to a lower amount and verify that it times out as expectedRelated issue/s
How to test
Dev Checklist
dynamic-scheduler
now explicitly capturesDYNAMIC_SCHEDULER_STOP_SERVICE_TIMEOUT
DevOps Checklist