Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Extending logging while starting new style dynamic services #5171

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 14, 2023

What do these changes do?

Something is fishy with the internals of the director-v2. Without any external inputs it decides to shut down services.

Adding some extra log lines in oder to figure out what exactly is causing this.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Dec 14, 2023
@GitHK GitHK added this to the Kobayashi Maru milestone Dec 14, 2023
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Dec 14, 2023
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #5171 (75178ce) into master (0288e6d) will decrease coverage by 18.8%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5171      +/-   ##
=========================================
- Coverage    87.3%   68.5%   -18.8%     
=========================================
  Files        1280     529     -751     
  Lines       52485   26746   -25739     
  Branches     1140     198     -942     
=========================================
- Hits        45866   18346   -27520     
- Misses       6374    8350    +1976     
+ Partials      245      50     -195     
Flag Coverage Δ
integrationtests 65.0% <100.0%> (+<0.1%) ⬆️
unittests 85.0% <0.0%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c_sidecar/scheduler/_core/_events_user_services.py 86.6% <100.0%> (+0.1%) ⬆️

... and 1011 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review December 14, 2023 12:15
@GitHK GitHK enabled auto-merge (squash) December 14, 2023 13:33
@GitHK GitHK merged commit dcbb1ad into ITISFoundation:master Dec 14, 2023
54 checks passed
@GitHK GitHK deleted the pr-osparc-extra-logs-in-schduler branch December 14, 2023 15:30
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants