Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Put less noise to RUT logging #5170

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Dec 13, 2023

What do these changes do?

  • ♻️ change log level from error to warning in one special case
    • NOTE: ANE/MD discussed. When the RUT receives a stop event and has not received before any start or heartbeat event, it probably means that we failed to start the container.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 30 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review December 13, 2023 13:27
@matusdrobuliak66 matusdrobuliak66 self-assigned this Dec 13, 2023
@matusdrobuliak66 matusdrobuliak66 requested review from pcrespov, sanderegg and GitHK and removed request for pcrespov December 13, 2023 13:27
@matusdrobuliak66 matusdrobuliak66 added this to the Kobayashi Maru milestone Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #5170 (9410724) into master (d25ad16) will decrease coverage by 20.9%.
The diff coverage is 50.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5170      +/-   ##
=========================================
- Coverage    86.5%   65.7%   -20.9%     
=========================================
  Files        1280     560     -720     
  Lines       52485   27738   -24747     
  Branches     1140     198     -942     
=========================================
- Hits        45444   18237   -27207     
- Misses       6796    9451    +2655     
+ Partials      245      50     -195     
Flag Coverage Δ
integrationtests 64.9% <ø> (+5.7%) ⬆️
unittests 87.2% <50.0%> (+1.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...usage_tracker/resource_tracker_process_messages.py 81.2% <50.0%> (ø)

... and 1052 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 merged commit 0288e6d into ITISFoundation:master Dec 13, 2023
54 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the improve-rut-logging branch December 14, 2023 11:54
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants